--
v3: win32u: Pass the rect DPI to NtUserIsWindowRectFullScreen.
win32u: Introduce a new get_monitor_rect helper.
win32u: Pass desired DPI to NtUserGet(Client|Window)Rect.
win32u: Introduce NtUserAdjustWindowRect call for AdjustWindowRect*.
win32u: Introduce new helpers to convert server rectangle_t.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5776
Jacek Caban (@jacek) commented about dlls/wininet/http.c:
>
> if (maxlen == -1) maxlen = sizeof(req->read_buf);
>
> + NETCON_set_timeout(req->netconn, FALSE, req->hdr.receive_timeout);
Setting the timeout on the socket is quite expensive (requires a wineserver call). Maybe we could store the last set timeout separate from configure timeout and update socket timeout only when they don't match?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72541
It looks better, thanks. In addition to minor comments, please split it. Additional `NETCON_set_timeout` fix is a separate fix from setting/getting options. Maybe also separate `NETCON_set_timeout` for send and receive.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72542
Jacek Caban (@jacek) commented about dlls/wininet/internet.c:
> + if (!lpwhh)
> + {
> + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE);
> + return FALSE;
> + }
> + if (!lpBuffer || dwBufferLength != sizeof(ULONG))
> + {
> + SetLastError(ERROR_INVALID_PARAMETER);
> + ret = FALSE;
> + }
> + else
> + {
> + lpwhh->connect_timeout = *(ULONG *)lpBuffer;
> + }
> + break;
> + }
Do we still need it? I think that with implementation in both `set_global_option` and `INET_SetOption`, we could simply remove those cases from `InternetSetOptionW` fallback.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72540