- wine-gitlab - winehq.org

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > > struct location where; > > - unsigned int declonly : 1; > + /* Should we define the UDT in this var, when writing a header? */ > + bool define; This is the first and only use of `bool` in widl. Later, you're also introducing a new `unsigned int :1` field elsewhere. I think something like `is_definition` is also more appropriate for an object property. Same below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71398

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/parser.y: > tVOID { $$ = type_new_void(); } > | base_type { $$ = $1; } > | enumdef { $$ = $1; } > - | tENUM aIDENTIFIER { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > + | tENUM typename { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > | structdef { $$ = $1; } > - | tSTRUCT aIDENTIFIER { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > + | tSTRUCT typename { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > | uniondef { $$ = $1; } > - | tUNION aIDENTIFIER { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > + | tUNION typename { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > | tSAFEARRAY '(' type ')' { $$ = make_safearray($3); } > | aKNOWNTYPE { $$ = find_type_or_error(current_namespace, $1); } > ; As you're changing tabs into space, could you fix them in the entire `unqualified_type` rule? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71397

1 0

Re: [PATCH 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found.
by Huw Davies (＠huw) 28 May '24

28 May '24

We'll want to keep both copies of `merge_devmode()` in sync, so please combine these two commits into one. Also, the subject of the commit message seems to have word-wrapped - please keep it as a single line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5720#note_71393

1 0

Re: [PATCH 0/2] MR5729: Fix SQLSetConnectOptionW prototype - approved
by Hans Leidekker (＠hans) 28 May '24

28 May '24

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5729

1 0

Re: [PATCH v3 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Sun May 26 17:37:57 2024 +0000, Nikolay Sivov wrote: > I think this is would be better if done in para_set_fmt(). Instead of 32 > please use MAX_TAB_STOPS or ARRAY_SIZE(). Thanks, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71383

1 0

Re: [PATCH 0/3] MR5710: win32u: Get rid of the UpdatedDisplayDevices force parameter. - approved
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5710

1 0

Re: [PATCH v3 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Sun May 26 17:37:57 2024 +0000, Nikolay Sivov wrote: > It makes more sense to test EM_GET* results here. Thanks, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71382

1 0

Re: [PATCH 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/riched20/editor.c: > } > case EM_SETPARAFORMAT: > { > - BOOL result = editor_set_selection_para_fmt( editor, (PARAFORMAT2 *)lParam ); > + BOOL result; > + PARAFORMAT2 fmt = *(PARAFORMAT2 *)lParam; > + fmt.cTabCount = max(0, min(fmt.cTabCount, 32)); /* Clamp between 0 and 32 */ > + result = editor_set_selection_para_fmt(editor, &fmt); I think this is would be better if done in para_set_fmt(). Instead of 32 please use MAX_TAB_STOPS or ARRAY_SIZE(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71380

1 0

Re: [PATCH 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Nikolay Sivov (@nsivov) commented about dlls/riched20/tests/editor.c: > SendMessageW(richedit, EM_GETPARAFORMAT, 0, (LPARAM)&pf); > ok(pf.wAlignment == align_mask[i], "got %d expect %ld\n", pf.wAlignment, align_mask[i]); > > + /* Test out of bounds tab count */ > + pf.cTabCount = -25000; > + SendMessageW(richedit, EM_SETPARAFORMAT, 0, (LPARAM)&pf); > + ok(pf.cTabCount == -25000, "Got %d\n", pf.cTabCount); > + pf.cTabCount = 25000; > + SendMessageW(richedit, EM_SETPARAFORMAT, 0, (LPARAM)&pf); > + ok(pf.cTabCount == 25000, "Got %d\n", pf.cTabCount); It makes more sense to test EM_GET* results here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71379

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > It's worth noting that we already have multiple > `STATUS_SUCCESS`-returning WoW64 stubs: > - `wow64_NtSetInformationProcess(ProcessInstrumentationCallback)`, at > dlls/wow64/process.c:896 ([gitlab][gitlab-sip], [cgit][cgit-sip]) > - `wow64_NtQueryMultipleValueKey`, at dlls/wow64/registry.c:364 > ([gitlab][gitlab-mvk], [cgit][cgit-mvk]) > - `wow64_NtCreateLowBoxToken`, at dlls/wow64/security.c:134 > ([gitlab][gitlab-clbt], [cgit][cgit-clbt]) > - `wow64_NtSetInformationJobObject(JobObjectBasicUIRestrictions)`, at > dlls/wow64/sync.c:1331 ([gitlab][gitlab-sijo], [cgit][cgit-sijo]) > A possible concern is that someone might introduce inconsistency in the > future, by forgetting to update the WoW64 stub when the syscall itself > is implemented. > Fortunately, I'm optimistic that we'll start testing wow64 regularly > before it becomes the new default, so maybe we just need a test in > `advapi32:security` to catch such oversight leading to inconsistency. > (That said, many of the above need proper tests too.) > [gitlab-sip]: <https://gitlab.winehq.org/wine/wine/-/blob/b210a204137dec8d2126ca909d762454…> > [cgit-sip]: <https://source.winehq.org/git/wine.git/blob/b210a204137dec8d2126ca909d76245…> > [gitlab-mvk]: <https://gitlab.winehq.org/wine/wine/-/blob/b210a204137dec8d2126ca909d762454…> > [cgit-mvk]: <https://source.winehq.org/git/wine.git/blob/b210a204137dec8d2126ca909d76245…> > [gitlab-clbt]: <https://gitlab.winehq.org/wine/wine/-/blob/b210a204137dec8d2126ca909d762454…> > [cgit-clbt]: <https://source.winehq.org/git/wine.git/blob/b210a204137dec8d2126ca909d76245…> > [gitlab-sijo]: <https://gitlab.winehq.org/wine/wine/-/blob/b210a204137dec8d2126ca909d762454…> > [cgit-sijo]: <https://source.winehq.org/git/wine.git/blob/b210a204137dec8d2126ca909d76245…> Alright, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71344

1 0

2025

2024

2023

2022

wine-gitlab