This format is used by many Unity games, with D3D-enabled source reader.
--
v4: mfreadwrite/reader: Fixup MFVideoFormat_ABGR32 subtype to enumerate the video processor.
winegstreamer: Support MFVideoFormat_ABGR32 output in the video processor.
mfreadwrite/tests: Add tests with MFVideoFormat_ABGR32 output format.
mf/tests: Add video processor tests with MFVideoFormat_ABGR32 format.
mfplat: Add MFVideoFormat_ABGR32 format information.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5626
On Thu May 16 13:27:46 2024 +0000, eric pouech wrote:
> I see your point. Note that the other way around (pseudo "datatypes" for
> function in template argument list) is not correctly detected either
> (eg. in `"?AU?$my_iter@H$0A@Z@@"`)
> and goes down to demangle_datatype
> so I think we should be symmetrical between functions' arg list and
> template arg list
> and hence:
> - move out of demangle_datatype non real data types ($$V as you did, Z
> for ...)
> - handle the end of list cases before calling demangle_datatype
> something like this could do [err](/uploads/314e62b635f2bfcfce46544ac03aaef1/err)
> (not ready for inclusion yet: we don't have test for generating template
> arg list as '<>')
Yes, I think it's better to also move Z and X handling out of demangle_datatype.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70684
This format is used by many Unity games, with D3D-enabled source reader.
--
v3: mfreadwrite/reader: Fixup MFVideoFormat_ABGR32 subtype to enumerate the video processor.
winegstreamer: Support MFVideoFormat_ABGR32 output in the video processor.
mfreadwrite/tests: Add tests with MFVideoFormat_ABGR32 output format.
mf/tests: Add video processor tests with MFVideoFormat_ABGR32 format.
mfplat: Add MFVideoFormat_ABGR32 format information.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5626
On Wed May 15 17:36:27 2024 +0000, Piotr Caban wrote:
> This marker is specific to templates so it doesn't really belong to
> `demangle_datatype` function. The patch you have proposed e.g.
> incorrectly demangles `??__K_l@@YA?AUCC@@I$$VI@Z`.
I see your point. Note that the other way around (pseudo "datatypes" for function in template argument list) is not correctly detected either (eg. in `"?AU?$my_iter@H$0A@Z@@"`)
and goes down to demangle_datatype
so I think we should be symmetrical between functions' arg list and template arg list
and hence:
- move out of demangle_datatype non real data types ($$V as you did, Z for ...)
- handle the end of list cases before calling demangle_datatype
something like this could do [err](/uploads/314e62b635f2bfcfce46544ac03aaef1/err)
(not ready for inclusion yet: we don't have test for generating template arg list as '<>')
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5646#note_70661
On Thu May 16 13:27:29 2024 +0000, Rémi Bernon wrote:
> Yes it doesn't send patches if there's not diff. If you want to test
> things on the testbot you can also directly submit patch files on
> https://testbot.winehq.org/Submit.pl (you need to register first).
Thanks for the info, I have requested an account. I see that you already scheduled a manual run so thanks for that too :)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5652#note_70662