- wine-gitlab - winehq.org

[PATCH 0/1] MR6904: Update NtQueryDirectoryFile to align with current Windows behaviour, and update tests accordingly
by Eugene McArdle (＠eugenemcardle) 27 Nov '24

27 Nov '24

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This test has been updated to only allow current Windows behaviour, and `NtQueryDirectoryFile` will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE` as appropriate. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

5 6

[PATCH 0/13] MR6910: mshtml: Implement proper prototype chain for elements.
by Gabriel Ivăncescu (＠insn) 27 Nov '24

27 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6910

3 17

[PATCH v3 0/2] MR6794: user32: Add PackTouchHitTestingProximityEvaluation stub.
by Vijay Kiran Kamuju (＠infyquest) 27 Nov '24

27 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56709 -- v3: user32: Add EvaluateProximityToRect stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6794

3 3

[PATCH v25 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 27 Nov '24

27 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options. https://bugs.winehq.org/show_bug.cgi?id=56068 -- v25: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

4 4

[PATCH 0/2] MR6912: msvcp120/tests: Add tests for _Fiopen.
by Daniel Lehman (＠dlehman25) 27 Nov '24

27 Nov '24

splitting out part of https://gitlab.winehq.org/wine/wine/-/merge_requests/6680 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6912

3 3

[PATCH v4 0/3] MR6891: cmd: Use CD /D to change directory in POPD (same as PUSHD).
by huangqinjin (＠huangqinjin) 27 Nov '24

27 Nov '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57137 -- v4: cmd: Use CD /D to change directory in POPD (same as PUSHD). cmd: Refactor CD command. https://gitlab.winehq.org/wine/wine/-/merge_requests/6891

3 7

Re: [PATCH v13 0/3] MR6737: comctl32/toolbar: forward WM_NOTIFY CBEN_ENDEDITW
by Zhiyi Zhang (＠zhiyi) 27 Nov '24

27 Nov '24

Hi, this is the third time that I had to remind you that the Wine project requires you to provide your full and real name before accepting your patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_89015

1 0

[PATCH v38 0/6] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) 27 Nov '24

27 Nov '24

-- v38: wintypes: Add stubs for IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet. wintypes: Add stubs for IMap<HSTRING, IInspectable *> to PropertySet. wintypes: Add stubs for IObservableMap<HSTRING, IInspectable *> to PropertySet. wintypes: Add stubs for Windows.Foundation.Collections.PropertySet. wintypes/tests: Add conformance tests for Windows.Foundation.Collections.PropertySet. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

4 17

[PATCH v3 0/2] MR6898: comctl32: Update combobox dropdown size.
by Orin Varley (＠ovarley1) 27 Nov '24

27 Nov '24

When the combobox height is to be set by the application (as the CBS_NOINTEGRALHEIGHT style is on), and when a large size is specified but only a small number of items in the list, the height of the combobox should be set by the number of items rather than the size specified to avoid empty lines. The first commit fixes this and the second is a test for this behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57360 Closes #7 -- v3: comctl32: Make CBS_NOINTEGRALHEIGHT only set minimum combobox height. comctl32/tests: Add tests for a small number of items but big size to the combobox dropdown size tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6898

4 7

[PATCH 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Zhiyi Zhang (＠zhiyi) 27 Nov '24

27 Nov '24

WaitCompletionPacket is a kernel object that, when associated with a target object and a completion object and when the target object is signaled, adds the completion information stored in itself to the completion object. For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911

3 8

2025

2024

2023

2022

wine-gitlab