On Mon Mar 25 12:06:39 2024 +0000, Nikolay Sivov wrote:
> It is correct. We should check for negative values only. Constant
> evaluated expressions are not allowed.
We should have tests for that then; I don't think we do currently.
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_66028
When present, the aperture indicates the area of the sample's buffers to display. The frame size instead includes some undesired padding. This is the case when color planes are aligned, such as with YUV output from a decoder MFT.
--
v3: evr/mixer: Respect input media type MF_MT_GEOMETRIC_APERTURE.
evr/tests: Add more video mixer input media type aperture tests.
evr/tests: Split check_presenter_output to a separate helper.
evr/tests: Split create_d3d_sample to a separate helper.
mf/tests: Check that pan scan and geometric apertures are set.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5297
When present, the aperture indicates the area of the sample's buffers to display. The frame size instead includes some undesired padding. This is the case when color planes are aligned, such as with YUV output from a decoder MFT.
--
v2: evr/mixer: Respect input media type MF_MT_GEOMETRIC_APERTURE.
evr/tests: Add more video mixer input media type aperture tests.
evr/tests: Split check_presenter_output to a separate helper.
evr/tests: Split create_d3d_sample to a separate helper.
mf/tests: Check that pan scan and geometric apertures are set.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5297
With some intermediate refactoring to make the code simpler.
I believe the failures that happened previously were coming from how NtGdiDdDDIOpenAdapterFromLuid initialized desc->hAdapter in win32u while winex11 was then relying on it. I missed this detail before and it should be working fine now that the vulkan path is only used to retrieve the physical device.
--
v3: win32u: Move D3DKMT vulkan implementation out of winex11.
winex11: Introduce a new find_adapter_from_handle helper.
winex11: Introduce a new get_vulkan_physical_device helper.
winex11: Initialize D3DKMT vulkan instance only once.
win32u: Open adapters in NtGdiDdDDIEnumAdapters2 outside of the display devices lock.
https://gitlab.winehq.org/wine/wine/-/merge_requests/5306
On Fri Mar 22 21:12:59 2024 +0000, Zebediah Figura wrote:
> You could probably avoid the duplication with a separate "%empty |
> [int]" rule. Or alternatively use "arrays" and add an explicit check for
> count > 1.
> Is C_INTEGER correct here, or should we allow compile-time constants?
It is correct. We should check for negative values only. Constant evaluated expressions are not allowed.
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739#note_65991
This is a split from MR3572. It's needed for Underworld Island (2150830) video seeking.
Changes compared to the patches in MR3572:
1. Avoid making session state changes when in paused state.
2. Add tests to show that the MF_MEDIA_ENGINE_EVENT_SEEKING notification is most likely blocking because notify->seeking_event_received is TRUE right after a SetCurrentTime() call. Same for MF_MEDIA_ENGINE_EVENT_TIMEUPDATE when in paused state.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5130