- wine-gitlab - winehq.org

[PATCH v7 0/6] MR7932: mf: Restart transforms and sinks on seek.
by Brendan McGrath (＠redmcg) 21 Jul '25

21 Jul '25

This MR fixes seek in VRChat by copying the sequence of flushes/stop/starts that Windows does. The order on Windows is: 1. Stop sources; 2. Flush MFTs; 3. Start sources; 4. Request output down the chain of sink inputs; 6. Flush sinks; and 7. Start the clock This takes place whether we pause before we seek or seek without pause. Changes in version 2: 1. Add test to see when SAR requests new samples; 2. Add test to examine when step 4 from above takes place; 3. Adjust the seek implementation in `mf/session.c` to match findings from the new tests; 4. Adjust `mfmediaengine` to reflect findings from the new tests; 5. Refactored `if` statement in `session_start` to be a `switch` again -- v7: mfmediaengine: Request sample if we are seeking. mfmediaengine: Don't perform implicit flush on state change. mf: Don't send MFT_MESSAGE_NOTIFY_START_OF_STREAM when seeking. mf: Restart transforms and sinks on seek. mf/tests: Test sequence of calls during a Pause and Seek. mf/tests: Test when SAR requests a new sample. https://gitlab.winehq.org/wine/wine/-/merge_requests/7932

3 9

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

On Mon Jul 21 10:45:21 2025 +0000, Nikolay Sivov wrote: > It's a change that we don't need, that's my point. Okay. I will keep the old name. It's not that important anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110515

1 0

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

On Mon Jul 21 12:47:05 2025 +0000, Nikolay Sivov wrote: > > So that versioned window classes gets registered as well. > Otherwise, comctl32 v6 fails to register > > its window classes when comctl32 v5 classes are still being used. > This can happen, for example, when > > creating a window using comctl32 v5, then unload comctl32 v5 and > not destroying the window, and then > > load comctl32 v6. > Is this still true? This shouldn't happen if things are working correctly. Yes. I think it's still true. You can use [print_v6_classes.txt](/uploads/f539fad83dd5c5088b5ea72dab2b344a/print_v6_classes.txt) and run misc tests. You can see that some comctl32 classes are not registered with "6.0.2600.2982!" prefix. ``` 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysAnimate32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"ComboBoxEx32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysDateTimePick32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"flatsb_class32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysHeader32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"msctls_hotkey32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysIPAddress32" hinst=0x140000000 style=0x400b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysListView32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysMonthCal32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"NativeFontCtl" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysPager" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"msctls_progress32" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"ReBarWindow32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"msctls_statusbar32" hinst=0x140000000 style=0x4009 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysLink" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysTabControl32" hinst=0x140000000 style=0x400b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"ToolbarWindow32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"tooltips_class32" hinst=0x140000000 style=0x4808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"msctls_trackbar32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"SysTreeView32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"msctls_updown32" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Static" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Button" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboBox" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboLBox" hinst=0x140000000 style=0x24808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboBox" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboLBox" hinst=0x140000000 style=0x24808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ListBox" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Static" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 ``` After the fix: ``` 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysAnimate32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboBoxEx32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysDateTimePick32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"flatsb_class32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysHeader32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!msctls_hotkey32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysIPAddress32" hinst=0x140000000 style=0x400b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysListView32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysMonthCal32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!NativeFontCtl" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysPager" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!msctls_progress32" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ReBarWindow32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!msctls_statusbar32" hinst=0x140000000 style=0x4009 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysLink" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysTabControl32" hinst=0x140000000 style=0x400b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ToolbarWindow32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!tooltips_class32" hinst=0x140000000 style=0x4808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!msctls_trackbar32" hinst=0x140000000 style=0x4000 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!SysTreeView32" hinst=0x140000000 style=0x4008 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!msctls_updown32" hinst=0x140000000 style=0x4003 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Static" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Button" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboBox" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboLBox" hinst=0x140000000 style=0x24808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboBox" hinst=0x140000000 style=0x408b clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ComboLBox" hinst=0x140000000 style=0x24808 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Edit" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!ListBox" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 00f0:fixme:class:NtUserRegisterClassExWOW name=L"6.0.2600.2982!Static" hinst=0x140000000 style=0x4088 clExtr=0x0 winExtr=0x8 ``` As for why datetime.c tests have been succeeding previously. It's because comctl32.dll gets unloaded and then loads again, even though a window created from a comctl32 window class is still active, probably due to some refcount issue that happens to make it work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110516

1 0

[PATCH v4 0/1] MR3579: oleaut32: Implement ICreateTypeLib2 DeleteTypeInfo
by Alistair Leslie-Hughes (＠alesliehughes) 21 Jul '25

21 Jul '25

-- v4: oleaut32: Implement ICreateTypeLib2 DeleteTypeInfo https://gitlab.winehq.org/wine/wine/-/merge_requests/3579

4 3

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Nikolay Sivov (＠nsivov) 21 Jul '25

21 Jul '25

> So that versioned window classes gets registered as well. Otherwise, comctl32 v6 fails to register > its window classes when comctl32 v5 classes are still being used. This can happen, for example, when > creating a window using comctl32 v5, then unload comctl32 v5 and not destroying the window, and then > load comctl32 v6. Is this still true? This shouldn't happen if things are working correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110509

1 0

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Nikolay Sivov (＠nsivov) 21 Jul '25

21 Jul '25

On Mon Jul 21 08:04:25 2025 +0000, Zhiyi Zhang wrote: > > Is there an embedded manifest in comctl32.dll from system32? > No. The manifest seems to be from somewhere else. Anyway, I think it's > clearer that the manifest is for comctl32 v6 this way. It's a change that we don't need, that's my point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110508

1 0

[PATCH v2 0/1] MR8533: fonts: Make numbers bold for WineTahomaBold.
by Ziqing Hui (＠zhui) 21 Jul '25

21 Jul '25

The glyphs are based on BitstreamVeraSans-Bold. The glyphs in WineTahomaBold are not truely bold, this font is just a copy of WineTahoma. If this patch is acceptable, I'm planning to make more glyphs bold, including at least all ASCII characters. -- v2: fonts: Make numbers bold for WineTahomaBold. https://gitlab.winehq.org/wine/wine/-/merge_requests/8533

3 4

[PATCH 0/1] MR8610: crypt32: Retry with CRYPT_MACHINE_KEYSET in CRYPT_AcquirePrivateKeyFromProvInfo().
by Hans Leidekker (＠hans) 21 Jul '25

21 Jul '25

Debugged by Katharina Bogad. Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=58528 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8610

2 1

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

> it doesn't matter if our v5 has manifest or not. I think we don't have to care about that at this point. Yeah. We don't need to care about whether comctl32 v5 has a manifest or not at this point. The problem with this part of the code is that comctl32 v6 doesn't get some of its window class version from its manifest without this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110490

1 0

Re: [PATCH v7 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

On Mon Jul 21 08:03:29 2025 +0000, Nikolay Sivov wrote: > Another way would be to extend this builtin signature check to > optionally include installed module name instead of assuming it's the > same as a filename, so that we can specify comctl32_v6.dll there and > build everything as builtin. I don't know if it's easy, because it > requires variable length data. It will be a lot more work. First, we need to pack variable-length data into e_lfanew for every DLL/EXE(output_pe_file(),output_module16, etc). Then we need to change this signature parsing to support variable-length data(winedump, dbghelp, build_module() in NTDLL, ntdll DLL loader, setupapi fakedll support). There will probably be alignment issues to be handled. Also, increasing e_lfanew might increase the chance of anti-virus software misdetecting wine DLLs as malware. Overall, I don't think it's worth it to extend the built-in signature check for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8595#note_110489

1 0

2025

2024

2023

2022

wine-gitlab