- wine-gitlab - winehq.org

[PATCH v5 0/10] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) 12 Feb '24

12 Feb '24

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v5: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 12

Re: [PATCH v2 0/1] MR5050: kernelbase: Copy the read-only attribute from the source. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5050

1 0

[PATCH v2 0/2] MR5069: Draft: wininet: Avoid crash in InternetCreateUrl with scheme unknown.
by Bernhard Übelacker (＠bernhardu) 12 Feb '24

12 Feb '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33050 -- v2: wininet: Avoid crash in InternetCreateUrl with scheme unknown. wininet: Add missing assignment of return value. https://gitlab.winehq.org/wine/wine/-/merge_requests/5069

3 3

Re: [PATCH v14 0/7] MR4082: gdiplus: Implement font linking in GdipDrawString. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

1 0

Re: [PATCH v3 0/5] MR5048: jscript: ArrayBuffer and DataView implementations. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5048

1 0

Re: [PATCH v3 0/5] MR5049: CreateProcess and erroneous std handles. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5049

1 0

Re: [PATCH v4 0/2] MR277: cmd: Handle lines with just spaces in bracket blocks. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/277

1 0

Re: [PATCH v2 0/8] MR5065: wininet: Improve proxy configuration reading and writing. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5065

1 0

Re: [PATCH v3 0/5] MR5067: winex11: Refactor XInput2 initialization and request version 2.2. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5067

1 0

Re: [PATCH v4 0/1] MR5040: dmband: Implement getting/setting GUID_BandParam on band tracks. - approved
by Alexandre Julliard (＠julliard) 12 Feb '24

12 Feb '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5040

1 0

2025

2024

2023

2022

wine-gitlab