> Would it make sense to rename shader_select()/vp_enable()/fp_enable() to something like shader_apply_draw_state()/vp_apply_draw_state()/fp_apply_draw_state(), along the lines of wined3d_context_vk_apply_draw_state()?
Good idea; I'll make that change.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5053#note_60620
There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached.
Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not.
--
v19: dmime: Create a band track for MIDI segments.
dmime/test: Add test for getting band track from midi file.
dmime: Implement IDirectMusicTrack_Play for MIDI tracks.
dmime: Implement getting/setting TempoParam for MIDI tracks.
dmime: Parse set tempo meta events.
dmime: Parse MIDI tracks.
dmime: Add stubs for MIDI tracks
dmime: Parse MIDI headers.
dmime/test: add MIDI loading test
dmime/test: add MIDI loading test
https://gitlab.winehq.org/wine/wine/-/merge_requests/4982
There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached.
Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not.
--
v18: dmime: Create a band track for MIDI segments.
dmime/test: Add test for getting band track from midi file.
dmime: Implement IDirectMusicTrack_Play for MIDI tracks.
dmime: Implement getting/setting TempoParam for MIDI tracks.
dmime: Parse MIDI tracks.
https://gitlab.winehq.org/wine/wine/-/merge_requests/4982
Looking a bit closer, I notice that we don't set VK_DYNAMIC_STATE_DEPTH_BOUNDS. We should add that to dynamic_states[] in d3d12_pipeline_state_get_or_create_pipeline(). Perhaps that's a good argument for waiting for the tests to verify things work as intended though...
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60601
Fixes the following warning on clang-15:
```
dlls/ntdll/unix/dwarf.h:915:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value]
case DW_OP_abs: stack[sp] = labs(stack[sp]); break;
^
dlls/ntdll/unix/dwarf.h:915:45: note: remove the call to 'labs' since unsigned values cannot be negative
case DW_OP_abs: stack[sp] = labs(stack[sp]); break;
^~~~
```
Despite what it says the existing code was functioning correctly already though AFAICT.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5056
--
v2: mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_ADVANCED_VIDEO_PROCESSING.
mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_VIDEO_PROCESSING.
mfreadwrite/tests: Test source reader exposed transforms and types.
mfreadwrite/tests: Initialize test source stream types from descriptors.
https://gitlab.winehq.org/wine/wine/-/merge_requests/4983