- wine-gitlab - winehq.org

[PATCH v2 0/1] MR4832: ntdll: Improve NtQuerySystemInformation(SystemModuleInformationEx)
by Dāvis Mosāns (davispuh) (＠davispuh) 14 Jan '24

14 Jan '24

When League of Legends game released update 13.23 it stopped working in Wine. Initially we didn't know why it stopped working and due to anti-cheat it was quite difficult to figure out what exactly is happening and so we were just trying to implement random things. One of the differences when comparing previous version with this version was the addition of something like this to their anti-cheat: ```c size_t size = 0x100000; int finalClass = 0xef; char *buffer = malloc(size * finalClass); ULONG length; for (int informationClass=0x00, informationClass < finalClass; informationClass++) { NtQuerySystemInformation(informationClass, buffer + size * informationClass, size, &length); } // later use stuff from there, of course everything's highly obfuscated ``` Essentially this hides what exactly they need since it could be any of classes. So we started to implement most likely classes that might be used to work like they do in Windows. This MR contains improvement of `SystemModuleInformationEx` so result will match pretty much exactly how it would on Windows. I only didn't include more modules but if anyone ever needs that it's very simple to add those. Also one of the things I noticed is that on Windows even if you give smaller buffer size it will still fill it with data unlike current Wine implementation and this is true for most of classes. Anyway in the end it turned out not to be issue/needed but I think it still could be useful. -- v2: ntdll: Improve NtQuerySystemInformation(SystemModuleInformationEx) https://gitlab.winehq.org/wine/wine/-/merge_requests/4832

2 2

[PATCH 0/1] MR4832: ntdll: Improve NtQuerySystemInformation(SystemModuleInformationEx)
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

When League of Legends game released update 13.23 it stopped working in Wine. Initially we didn't know why it stopped working and due to anti-cheat it was quite difficult to figure out what exactly is happening and so we were just trying to implement random things. One of the differences when comparing previous version with this version was the addition of something like this to their anti-cheat: ```c size_t size = 0x100000; int finalClass = 0xef; char *buffer = malloc(size * finalClass); ULONG length; for (int informationClass=0x00, informationClass < finalClass; informationClass++) { NtQuerySystemInformation(informationClass, buffer + size * informationClass, size, &length); } // later use stuff from there, of course everything's highly obfuscated ``` Essentially this hides what exactly they need since it could be any of classes. So we started to implement most likely classes that might be used to work like they do in Windows. This MR contains improvement of `SystemModuleInformationEx` so result will match pretty much exactly how it would on Windows. I only didn't include more modules but if anyone ever needs that it's very simple to add those. Also one of the things I noticed is that on Windows even if you give smaller buffer size it will still fill it with data unlike current Wine implementation and this is true for most of classes. Anyway in the end it turned out not to be issue/needed but I think it still could be useful. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4832

3 2

[PATCH v3 0/4] MR4761: ntdll: Implement NtContinueEx()
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

This MR implements `NtContinueEx(PCONTEXT, PCONTINUE_OPTIONS)` which was added in Windows 10 20H1. Also added basic test reusing existing `test_continue()` (included from !4720) League of Legends game hooks `NtContinue()` and `NtContinueEx()` by putting `jmp` instruction in front of it. Note that LoL doesn't actually use `NtContinueEx()` itself and game will work fine without it but if game doesn't find `NtContinueEx()` it will permanently ban your account due to detecting "scripting program" -- v3: ntdll/tests: Add basic test for NtContinueEx() ntdll: NtContinueEx() handle few error cases ntdll: Implement NtContinueEx() ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4761

3 5

[PATCH v8 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v8: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 5

[PATCH v7 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v7: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 2

[PATCH 0/2] MR4836: ntdll: Implement SystemFirmwareTable_Enumerate in NtQuerySystemInformation
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

This MR implements `EnumSystemFirmwareTables()` and `NtQuerySystemInformation(SystemFirmwareTableInformation)` with `SystemFirmwareTable_Enumerate` which are currently not implemented. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4836

3 3

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Rémi Bernon (＠rbernon) 13 Jan '24

13 Jan '24

On Sat Jan 13 18:12:01 2024 +0000, Tyson Whitehead wrote: > Just a note that I have some more changes coming to this > * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) > * update the tests Only had a quick look so far and it looks okay, so feel free to add these too. Fwiw in general we prefer to add tests first, with todo_wine as needed, and then remove the todo_wine as things are implemented. This better shows the desired behavior which is being implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57341

1 0

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) 13 Jan '24

13 Jan '24

Just a note that I have some more changes coming to this * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) * update the tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57338

1 0

[PATCH 0/1] MR4833: ntdll: Improve NtQuerySystemInformation(SystemCodeIntegrityInformation)
by Dāvis Mosāns (davispuh) (＠davispuh) 13 Jan '24

13 Jan '24

This makes it match more closely how it works on Windows but it's still not a proper implementation. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4833

2 1

[PATCH 0/1] MR4831: wing32: Avoid crash in WinGGetDIBPointer when called with NULL bitmap info.
by Bernhard Übelacker (＠bernhardu) 13 Jan '24

13 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56135 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4831

3 2

2025

2024

2023

2022

wine-gitlab