- wine-gitlab - winehq.org

Re: [PATCH v3 0/3] MR8503: mshtml: document.open and link color fixes. - approved
by Alexandre Julliard (＠julliard) 05 Jul '25

05 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8503

1 0

Re: [PATCH v2 0/3] MR8417: ntoskrnl.exe: Implement Io{Get,Set}DeviceInterfacePropertyData. - approved
by Alexandre Julliard (＠julliard) 05 Jul '25

05 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8417

1 0

Re: [PATCH v2 0/1] MR8236: dxcore/tests: Skip tests when there is no display available. - approved
by Alexandre Julliard (＠julliard) 05 Jul '25

05 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8236

1 0

Re: [PATCH v2 0/1] MR8492: inetcpl: Restore parse_url_from_outside implementation. - approved
by Alexandre Julliard (＠julliard) 05 Jul '25

05 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8492

1 0

Re: [PATCH v4 0/1] MR8382: msvcr120/tests: Add tests for expf. - approved
by Alexandre Julliard (＠julliard) 05 Jul '25

05 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8382

1 0

[PATCH 0/1] MR8488: d3dcompiler: Use __WINE_CRT_PRINTF_ATTR.
by Jacek Caban (＠jacek) 05 Jul '25

05 Jul '25

This enables the format attribute in Clang builds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8488

3 2

[PATCH v5 0/1] MR8466: ntdll: Also restore rbp before calling user mode callback.
by Yuxuan Shui (＠yshui) 05 Jul '25

05 Jul '25

If wine dlls are built with frame pointers enabled, the frame pointer will be used during unwinding. If we don't restore frame pointer before calling the user mode callback, then later when the unwinder encounters the user mode callback frame, it will set the frame pointer to something unexpected (depends on what it was during `call_user_mode_callback`). Then for the subsequent frame it adjusts the stack pointer based on the frame pointer, thus derailing the unwinding process. -- v5: ntdll: Also restore rbp before calling user mode callback. https://gitlab.winehq.org/wine/wine/-/merge_requests/8466

3 12

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) 05 Jul '25

05 Jul '25

eric pouech (@epo) commented about programs/conhost/conhost.c: > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); > + unsigned int len = line ? lstrlenW(line) : 0; > + > + if (len > ctx->cursor) > + { > + unsigned int ccount = (copycount > 0) ? copycount : len - ctx->cursor; > + > + /* Clean the screen. */ > + edit_line_delete(console, ctx->cursor, ctx->len); > + /* Insert new string. */ > + if (edit_line_grow(console, len + 1)) this will overallocate -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108892

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) 05 Jul '25

05 Jul '25

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); > + unsigned int len = line ? lstrlenW(line) : 0; > + > + if (len > ctx->cursor) it looks like native is doing stuff a bit more complicated: * the MR implements the case where cursor is at the end of edit line * if cursor is not at the end, it looks native just advance cursor by ccount -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108891

1 0

Re: [PATCH v4 0/1] MR8467: conhost: Implement F1 and F3 support for history retrieval.
by eric pouech (＠epo) 05 Jul '25

05 Jul '25

eric pouech (@epo) commented about programs/conhost/conhost.c: > while (ctx->history_index != start_pos); > } > > +static void edit_line_copy_from_hist( struct console *console, int copycount ) > +{ > + if (console->edit_line.history_index) > + { > + unsigned int index = console->edit_line.history_index - 1; > + struct edit_line *ctx = &console->edit_line; > + WCHAR *line = edit_line_history(console, index); since you're not changing the `console->history` content, you could access `console->history[index]` directly (that would save recomputing the length, and one allocation) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8467#note_108890

1 0

2025

2024

2023

2022

wine-gitlab