- wine-gitlab - winehq.org

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_format.c: > if (gst_video_info_from_caps(&info, caps)) > wg_format_from_video_info(format, &info); > } > - else if (!strcmp(name, "audio/mpeg")) > + else if (!strcmp(name, "audio/mpeg") && gst_structure_get_boolean(structure, "parsed", &parsed) && parsed) This is correct, I think, but also orthogonal to the purpose of this patch. Can you please split this out into a separate patch? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48897

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

On Mon Oct 16 21:55:32 2023 +0000, Alfred Agrell wrote: > Unfortunately, we do. I had sleeps everywhere during development, then > removed every one I could, but that specific one is load-bearing. > https://testbot.winehq.org/JobDetails.pl?Key=138782&f101=exe64.report > https://testbot.winehq.org/JobDetails.pl?Key=138783&f101=exe64.report > I tried swapping it for IBaseFilter_GetState(), but that just returned > immediately then gave the same segfault. https://testbot.winehq.org/JobDetails.pl?Key=138786&f101=exe64.report > Calling GetState twice worked, but I'm pretty sure that's just because > those calls take long enough to satisfy its timing demands. A sleep is > cleaner. (Slightly. Still ugly.) > I could also move the sleep, but I don't think that would accomplish anything. Hrm, that's suspicious, IMemAllocator::GetBuffer() returns VFW_E_NOT_COMMITTED. Does the VMR's IMemAllocator change by any chance when we reconnect? I.e. is IMemInputPin::GetAllocator() actually returning the same allocator that it was returning before? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48893

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 16 Oct '23

16 Oct '23

On Mon Oct 16 21:25:57 2023 +0000, Zebediah Figura wrote: > Do we still need this? Unfortunately, we do. I had sleeps everywhere during development, then removed every one I could, but that specific one is load-bearing. https://testbot.winehq.org/JobDetails.pl?Key=138782&f101=exe64.report https://testbot.winehq.org/JobDetails.pl?Key=138783&f101=exe64.report I tried swapping it for IBaseFilter_GetState(), but that just returned immediately then gave the same segfault. https://testbot.winehq.org/JobDetails.pl?Key=138786&f101=exe64.report Calling GetState twice worked, but I'm pretty sure that's just because those calls take long enough to satisfy its timing demands. A sleep is cleaner. (Slightly. Still ugly.) I could also move the sleep, but I don't think that would accomplish anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48883

1 0

[PATCH 0/1] MR4111: winegstreamer: Implement IWMResamplerProps
by Fabian Maurer (＠DarkShadow44) 16 Oct '23

16 Oct '23

Some programs just assume this interface exists, this fixes the resulting crash. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55789 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4111

3 3

[PATCH 0/8] MR412: tests: Fix a number of tests so they pass on Windows.
by Giovanni Mascellani (＠giomasce) 16 Oct '23

16 Oct '23

This is a continuation to !406. With this MR all the tests pass on Windows. [The next step is to allow the CI to run crosstests on Windows](https://gitlab.winehq.org/giomasce/vkd3d/-/commits/ci3). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/412

3 9

[PATCH 0/7] MR4110: dmime: Simplify message thread and use latency time to schedule messages.
by Rémi Bernon (＠rbernon) 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4110

3 10

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/vmr9.c: > + hr = IMemAllocator_SetProperties(allocator, &req_props, &ret_props); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + hr = IMemAllocator_Commit(allocator); > + ok(hr == S_OK, "Got hr %#lx.\n", hr); > + > device2 = create_device(window); > ok(device2 != NULL, "Couldn't create device\n"); > > - ok(presenter.got_TerminateDevice == 0, "got %d\n", presenter.got_TerminateDevice); > - > hr = IVMRSurfaceAllocatorNotify9_ChangeD3DDevice(notify, device2, MonitorFromWindow(window, MONITOR_DEFAULTTOPRIMARY)); > ok(hr == S_OK, "Got hr %#lx.\n", hr); > - ok(presenter.got_TerminateDevice == 1, "got %d\n", presenter.got_TerminateDevice); > + presenter.device = device2; > + presenter.got_PresentImage = 0; > + Sleep(200); /* ChangeD3DDevice is partially asynchronous */ Do we still need this? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48875

1 0

Re: [PATCH v6 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) 16 Oct '23

16 Oct '23

> Found it. Native VMR9 disconnects and reconnects the pin when changing d3d device. Unfortunately, neither party remembers the media type, so they can't reconnect. > > Fixed. Took approximately seven forevers to figure out @\_@ Ah, that makes sense, thanks. That's done in some other filters as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_48874

1 0

[PATCH 0/1] MR4001: Draft: winegstreamer: Add hardware H264 decoding support
by Thong Thai (＠thongthai) 16 Oct '23

16 Oct '23

Signed-off-by: Thong Thai <thong.thai(a)amd.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4001

5 10

Re: [PATCH v2 0/2] MR4098: winewayland.drv: More robust handling of xdg_output information - approved
by Alexandre Julliard (＠julliard) 16 Oct '23

16 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4098

1 0

2025

2024

2023

2022

wine-gitlab