- wine-gitlab - winehq.org

[PATCH v5 0/3] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v5: Test. Second. First. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 3

[PATCH v3 0/1] MR474: Draft: Test running the shader runner on the correct test data on Windows.
by Giovanni Mascellani (＠giomasce) 15 Nov '23

15 Nov '23

So far this MR is just for experimentation, do not review it. -- v3: Test. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/474

2 1

[PATCH 0/1] MR4391: mshtml: Fix misleading-indentation warning.
by Bartosz Kosiorek (＠gang65) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4391

4 4

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by darkblaze69 (＠darkblaze69) 15 Nov '23

15 Nov '23

Hi, another bug: https://bugs.winehq.org/show_bug.cgi?id=55902 GNOME, cannot resize a window by touchpad double-tap -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_52338

1 0

[PATCH 0/1] MR4397: msvcp140: Add codecvt<char32> class stub.
by Jactry Zeng (＠jactry) 15 Nov '23

15 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47609 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4397

2 1

Re: [PATCH v3 0/12] MR471: Draft: vkd3d-shader/dxil: Implement the DXIL GEP and LOAD instructions.
by Conor McCarthy (＠cmccarthy) 15 Nov '23

15 Nov '23

On Wed Nov 15 06:54:38 2023 +0000, Henri Verbeet wrote: > > This needs spirv changes to make any tests pass, but this series is > already long enough. Not sure what to do about initialisers; we can't > use `DCL_IMMEDIATE_CONSTANT_BUFFER` because it emits a variable, > Is the issue purely that the shader may write to the variable, or are > there other reasons that can't work? If what we want is essentially a > writeable icb, we could perhaps consider adding a "data[]" field to the > vkd3d_shader_indexable_temp structure, analogous to struct vkd3d_shader_immediate_constant_buffer. What it really needed was a new value type to hold ICBs. Storing an ICB in the indexable temp declaration works well now. Constant arrays should be declared with `DCL_IMMEDIATE_CONSTANT_BUFFER`, but that must wait for the next MR. It's not broken, just ignores the constant attribute. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/471#note_52336

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + WCHAR buffer[500]; > + DWORD len; > + HRESULT (WINAPI *pDriverStoreFindDriverPackageW)(const WCHAR*, void*, void*, DWORD, void*, WCHAR*, DWORD*); > + > + library = LoadLibraryA("setupapi.dll"); > + ok(library != NULL, "Failed to load setupapi.dll\n"); > + if (!library) return; > + > + pDriverStoreFindDriverPackageW = (void *)GetProcAddress(library, "DriverStoreFindDriverPackageW"); > + if (!pDriverStoreFindDriverPackageW) > + { > + win_skip("Can't find DriverStoreFindDriverPackageW\n"); > + return; > + } > + > + len = 500; Rather than initializing len with a magic number here, it would be more clear declare the variable as `DWORD len = ARRAY_SIZE(buffer)` to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52331

1 0

Re: [PATCH v3 0/1] MR4343: setupapi: Add stub for DriverStoreFindDriverPackageW
by Alex Henrie (＠alexhenrie) 15 Nov '23

15 Nov '23

Alex Henrie (@alexhenrie) commented about dlls/setupapi/tests/query.c: > + ok(result == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), "Got %lx\n", result); > + else > + todo_wine > + ok(result == E_INVALIDARG, "Got %lx\n", result); /* Win64 needs flags 0x9, or it gives invalid parameter */ > + > + /* Invalid parameter tests */ > + > + result = pDriverStoreFindDriverPackageW(L"c:\\nonexistant.inf", 0, 0, 9, 0, 0, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(0, 0, 0, 9, 0, buffer, &len); > + ok(result == E_INVALIDARG, "Got %lx\n", result); > + > + result = pDriverStoreFindDriverPackageW(L"", 0, 0, 9, 0, buffer, &len); > + todo_wine > + ok(result == 0x8007007b || result == E_INVALIDARG, "Got %lx\n", result); /* Win7 and Win10 have different results */ 0x8007007b is HRESULT_FROM_WIN32(ERROR_INVALID_NAME). Let's use the macro instead of a magic number, assume that ERROR_INVALID_NAME is broken behavior, and make Wine return E_INVALIDARG in this situation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4343#note_52330

1 0

[PATCH 0/2] MR4388: user32: Return DEFAULT_CHARSET from SPI_GETICONTITLELOGFONT and SPI_GETNONCLIENTMETRICS.
by Dmitry Timoshkov (＠dmitry) 15 Nov '23

15 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4388

3 3

[PATCH v10 0/1] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) 15 Nov '23

15 Nov '23

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v10: kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

4 4

2025

2024

2023

2022

wine-gitlab