- wine-gitlab - winehq.org

Re: [PATCH 0/6] MR3909: winewayland.drv: part 7: Basic window management - approved
by Rémi Bernon (＠rbernon) 22 Sep '23

22 Sep '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:50:36 2023 +0000, Aidan Khoury wrote: > `RtlImageNtHeader` lacks proper image boundary checks for e_lfanew, so > using it in this case is not safe. this raises the questions does native ntdll.RtlImageHeader check for e_lfanew being within image boundary? if so, it builtin implementation has to be fixed (with test case please) and if it doesn't you can still add the check on RtlImageHeader's returned value -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46285

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Thu Sep 21 20:03:38 2023 +0000, Aidan Khoury wrote: > No, but if you supply invalidly formed images to the mspatcha.dll APIs > it will raise an exception with code 0xE0000001. I made this a separate > function so I could mark it as `DECLSPEC_NORETURN`. (my question was unclear: I meant does native throw this exception?) what does native do if the exception is continued? (I doubt this helper can be DECLSPEC_NOTRETURN) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46284

1 0

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) 22 Sep '23

22 Sep '23

> What about If I changed the commit message to winmm: MCI_MapMsgAtoW return error code directly instead of a boolean. That's my point: it doesn't currently return a boolean, it returns a tri-state. One of those values tells the caller to skip calling `MCI_UnmapMsgAtoW()`. Your change gets rid of this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_46283

1 0

Re: [PATCH v35 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by eric pouech (＠epo) 22 Sep '23

22 Sep '23

On Fri Sep 22 06:33:23 2023 +0000, Aidan Khoury wrote: > Updated in https://gitlab.winehq.org/wine/wine/-/merge_requests/3870/diffs?diff_id=709… > :thumbsup: actually, if there's a bug in imagehlp.CalcCheckSum, the general way of handling is to write a test case that demonstrate the bug, and implement the fix in the offending function -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46282

1 0

[PATCH 0/1] MR3920: winecoreaudio: Use os_unfair_lock when available instead of OSSpinLock.
by Brendan Shanks (＠bshanks) 22 Sep '23

22 Sep '23

OSSpinLock is deprecated, Apple recommends os_unfair_lock as the improved replacement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3920

4 3

[PATCH v8 0/7] MR320: vkd3d-shader/dxil: Implement DX instruction LoadInput.
by Conor McCarthy (＠cmccarthy) 22 Sep '23

22 Sep '23

-- v8: vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. vkd3d-shader/d3d-asm: Trace undefined registers. vkd3d-shader: Make the paramater allocator slab size at least MAX_REG_OUTPUT. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/320

2 7

[PATCH v6 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 22 Sep '23

22 Sep '23

This goes on top of MR 320 and 345. -- v6: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. vkd3d-shader/d3d-asm: Trace undefined registers. vkd3d-shader: Make the paramater allocator slab size at least MAX_REG_OUTPUT. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 12

[PATCH 0/1] MR3921: ws2_32/tests: Add more tests for SO_REUSEADDR
by Ally Sommers (＠dropbear) 22 Sep '23

22 Sep '23

These are the tests from !3367 (Defer listens on addresses currently bound first by another socket). The tests marked `todo_wine` rely on a more accurate implementation of `SO_REUSEADDR`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3921

3 2

Re: [PATCH v7 0/3] MR3367: server: Defer listens on addresses currently bound first by another socket. - closed
by Ally Sommers (＠dropbear) 22 Sep '23

22 Sep '23

This merge request was closed by Ally Sommers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3367

1 0

2025

2024

2023

2022

wine-gitlab