- wine-gitlab - winehq.org

[PATCH 0/4] MR3329: winsock: Better cancel asyncs when socket handle is closed.
by Paul Gofman (＠gofman) 15 Jul '23

15 Jul '23

It turns out that Windows have a special behaviour WRT cancelling asyncs for terminating thread (or already terminated thread when socket handle is closed) when there is no more open handles in the process for the socket (while there might be handles to it in another processes). We currently have a logic on cancelling async in server/async.c:cancel_terminating_thread_asyncs() called before thread termination. It has a special case ("async->completion && async->data.apc_context && !async->event") when async is not canceled (covered by the tests). It turns out that on Windows, if there are no more handles to the socket in the async's process, async is cancelled even in this case. Then, if thread is terminated while there are open handles in the same process, but those handles are closed after that, it turns out the asyncs should be canceled the same way, even if there are handles for the socket in another process. Why this is important (and, actually, makes some sense to me), is that it is very easy to duplicate all the open handles to the child process. Just e. g., Qt doesn't seem to have any way to create a process through QtProcess without inheriting handles. Programs might expect that once they close socket handle the async operations will be aborted and they receive completions on port. But that doesn't happen if they didn't use an event for overlapped operation and happened to create any child process with inherited handles after creating the socket. Windows behaviour looks to me as a workaround for this. Besides the present test, I also tested the same with AcceptEx and IOCTL_AFD_RECV which behaves the same. Just to note, closing the handle before thread termination when there are no other open handles is quite a different case. In its heart it behaves *somewhat* similar on Windows and Wine but not quite, hitting various issues. But that looks unrelated to the special case concerned in this patchset. Fixes Battle.net hanging on exit during "update and restart" (not to confuse with update itself not finishing which is an unrelated issue related to file DACLs). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3329

3 25

[PATCH v4 0/5] MR3336: sapi: Miscellaneous fixes.
by Shaun Ren (＠shaunren) 15 Jul '23

15 Jul '23

-- v4: sapi/tests: Use SHDeleteKeyA instead of RegDeleteTreeA in token tests. sapi/tests: Fix ISpObjectToken::CreateInstance E_ACCESSDENIED error. sapi/tests: Fix intermittent duration test failure in mmaudio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3336

2 5

Re: [PATCH v2 0/7] MR3305: Remove DECLSPEC_HIDDEN DirectX - approved
by Nikolay Sivov (＠nsivov) 14 Jul '23

14 Jul '23

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3305

1 0

[PATCH 0/1] MR3317: d3dcompiler/tests: Add another test for matrix majority flags.
by Nikolay Sivov (＠nsivov) 14 Jul '23

14 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3317

3 4

Re: [PATCH v2 0/2] MR3326: wmp: Two crash fixes - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3326

1 0

Re: [PATCH v2 0/1] MR3325: shell32: Don't fall back to $HOME for missing user special folders. - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3325

1 0

Re: [PATCH v2 0/4] MR3335: include: Add ID2D1DeviceContext4 in d2d1_3.idl - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3335

1 0

Re: [PATCH v2 0/6] MR3320: wined3d: Move Vulkan declarations to wined3d_vk.h, part 3/3. - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3320

1 0

Re: [PATCH v2 0/1] MR3332: secur32/tests: Fix a test failure and extend tests. - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3332

1 0

Re: [PATCH v2 0/2] MR3327: opengl32: Fixes for wow64 buffer mapping. - approved
by Alexandre Julliard (＠julliard) 14 Jul '23

14 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3327

1 0

2025

2024

2023

2022

wine-gitlab