- wine-gitlab - winehq.org

Re: [PATCH v4 0/5] MR8438: cfgmgr32: Device Query API part 1: Add a basic implementation for DevGetObjects.
by Vibhav Pant (＠vibhavp) 30 Jun '25

30 Jun '25

On Fri Jun 27 20:34:30 2025 +0000, Vibhav Pant wrote: > changed this line in [version 4 of the diff](/wine/wine/-/merge_requests/8438/diffs?diff_id=189335&start_sha=047cdc41c97e2a1e39d221cc83e8b18b318c28c7#2c4a05158dcf4c9a716dbcdc3463badaebf121b3_28_28) Ah, missed this. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8438#note_108279

1 0

Re: [PATCH v4 0/5] MR8438: cfgmgr32: Device Query API part 1: Add a basic implementation for DevGetObjects.
by Vibhav Pant (＠vibhavp) 30 Jun '25

30 Jun '25

On Fri Jun 27 20:34:30 2025 +0000, Vibhav Pant wrote: > changed this line in [version 4 of the diff](/wine/wine/-/merge_requests/8438/diffs?diff_id=189335&start_sha=047cdc41c97e2a1e39d221cc83e8b18b318c28c7#ffd51de087e78a6f8a5f2f1d1131c2f4d41ba745_36_35) Yup, that's easier to read. Fixed, thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8438#note_108278

1 0

Re: [PATCH v2 0/6] MR8445: server: Create inproc sync events for message queues.
by Rémi Bernon (＠rbernon) 30 Jun '25

30 Jun '25

The comment is added in a later change, when it really matters. For now the entries aren't cached. Fwiw I kept a "cache" name for the stack variable but it should probably not even be named like that, it's not a cache. I don't think it matters much anyway, the code isn't so complicated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8445#note_108273

1 0

Re: [PATCH v2 0/6] MR8445: server: Create inproc sync events for message queues.
by Elizabeth Figura (＠zfigura) 30 Jun '25

30 Jun '25

``` +static NTSTATUS get_inproc_sync( HANDLE handle, struct inproc_sync *cache, struct inproc_sync **out ) ``` You've changed these parameter names to make them less clear, and gotten rid of the comment that explains what they're for. How is this an improvement? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8445#note_108272

1 0

[PATCH v3 0/2] MR8431: win32u: Mind window show command in startup info.
by Paul Gofman (＠gofman) 30 Jun '25

30 Jun '25

-- v3: win32u: Mind STARTF_USESHOWWINDOW in show_window(). user32/tests: Add tests for STARTF_USESHOWWINDOW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8431

3 5

Re: [PATCH v8 0/4] MR8390: sapi/tts: Add some SSML parsing tests and XML parsing flags support.
by Shaun Ren (＠shaunren) 30 Jun '25

30 Jun '25

On Fri Jun 27 15:38:57 2025 +0000, Huw Davies wrote: > After the third commit I'm getting > ``` > tts.c:1060: Test succeeded inside todo block: got 0. > ``` > which is fixed after the final commit. Fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8390#note_108256

1 0

[PATCH v6 0/5] MR5068: win32u: Fix rendering of the rotated and scaled text.
by Dmitry Timoshkov (＠dmitry) 30 Jun '25

30 Jun '25

These patches make a test case attached to the bug https://bugs.winehq.org/show_bug.cgi?id=33190 work. -- v6: win32u: NtGdiExtTextOutW() should translate x,y from logical to device units at the last step. win32u: Fix device<->world width/height converters. win32u: Use slightly more readable names for DP/LP converters. win32u: Use correct helper for converting width to device units. gdi32/tests: Add some tests for rotated font metrics. https://gitlab.winehq.org/wine/wine/-/merge_requests/5068

4 15

[PATCH 0/1] MR8452: Draft: gitlab: Set WINEPREFIX to a job workspace sub-directory.
by Rémi Bernon (＠rbernon) 30 Jun '25

30 Jun '25

Although I have trouble reproducing it I still experience weird test failures whenever I create or updated separate MRs in a short amount of time. These failures are usually coming from unexpected display settings, although each job is running within docker in an isolated environment. I don't have any explanation for this, and I have confirmed that separate X server are spawned. However, the prefix used for the tests is initialized to /home/gitlab/.wine and I suspect this could perhaps be mounted and shared across containers? It could also explain the failures, if, for instance wineserver starts while another instance (invisible as isolated in a separate container) is running and has updated the registry on disk with different display settings while the tests are being executed. This is hypothetical but nonetheless I think it's better to keep the prefix in a job workspace sub-directory. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8452

3 5

[PATCH 0/2] MR8451: Draft: ntdll: Grow mapped file on commit.
by Nikolay Sivov (＠nsivov) 30 Jun '25

30 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8451

2 3

[PATCH v3 0/5] MR8438: cfgmgr32: Device Query API part 1: Add a basic implementation for DevGetObjects.
by Vibhav Pant (＠vibhavp) 30 Jun '25

30 Jun '25

(Follow up from !6788) The goal is to use the device object API as the backend for Windows.Devices.Enumeration, as most concepts from the latter have a one-to-one mapping to the former: * The device object API is centred around the [`DEV_OBJECT`](https://learn.microsoft.com/en-us/windows/win32/api/devquerydef/ns-devquerydef-dev_object) type, which provides a unified representation for devnodes, device interfaces/containers, device interface classes, and association endpoints (networking protocols and service instances, like UPnP and Bluetooth), together with the properties associated with it. The [`DevObjectType`](https://learn.microsoft.com/en-us/windows/win32/api/devquerydef/ne-devquerydef-dev_object_type) enum maps to [`Windows.Devices.Enumeration.DeviceInformationKind`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformationkind?view=winrt-26100). This would be used to implement the [`DeviceInformation`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation?view=winrt-26100) class. * [`DEVPROP_FILTER_EXPRESSION`](https://learn.microsoft.com/en-us/windows/win32/api/devfiltertypes/ns-devfiltertypes-devprop_filter_expression) allows filtering device queries by their properties. AQS filter strings would be parsed into an array of filters, which are then passed to the query object methods. * `DevCreateObjectQuery` would be the backend for `DeviceWatcher`, as it provides asynchronous callbacks for initial device enumeration, device addition, removal and updates. * [`DevGetObjects`](https://learn.microsoft.com/en-us/windows/win32/api/devquery/nf-devquery-devgetobjects) would be used to implement the `FindAllAsync*` methods. This MR adds a basic implementation and tests for `DevGetObjects`. -- v3: cfgmgr32: Add a basic implementation for DevGetObjects(Ex) for device interface objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/8438

3 11

2025

2024

2023

2022

wine-gitlab