- wine-gitlab - winehq.org

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tomasz Pakuła (＠TomaszPakula) 08 Aug '25

08 Aug '25

On Fri Aug 8 21:48:51 2025 +0000, Tyson Whitehead wrote: > Right. That makes sense. I don't think, however, that this merge request > makes any devices work better. Instead I believe it just breaks > `DIPROP_AUTOCENTER` support in a lot of cases. > Specifically, wrt to devices that hidraw doesn't work (e.g., so UDEV > (input) or SDL are the only option) I expect > * all non-HID driver devices for which the kernel driver supported > autocenter (e.g., the I-FORCE) are now broken wrt `DIPROP_AUTOCENTER` > for all buses > with respect to devices where hidraw wouldn't work with autocenter, but > UDEV (input) or SDL would (e.g., devices that that don't turn autocenter > on on reset and off on stop all effects) > * all HID non-pidff driver devices for which the kernel driver support > autocenter (e.g., the Logitech WingMan Force) are now broken wrt > `DIPROP_AUTOCENTER` for all buses > and with respect to devices where hidraw does work with autocenter > (e.g., devices that do turn autocenter on on reset and off on stop all effects > * all HID pdiff driver devices for which the kernel driver supported > autocenter (e.g., the USB Sidewinder 2) are broken wrt > `DIPROP_AUTOCENTER` for all buses but hidraw > Unfortunately I don't have any of these devices to test apart for the > USB Sidewinder 2 to prove this. The best I could do was to do was write > a [test program](https://github.com/twhitehead/issue-wine-ff-autocenter) > so people with them could check. It sounds like @TomaszPakula has some > wheels to test. And perhaps @JacKeTUs has some non-HID devices to test > too or knows someone who does? I would really appreciate it if everyone > could test their device as, if I am correct, there is a lot of breakage here. > The only two things I see it _fixing_ is when autocenter is desired to > be off and > * the program assumes `DIPROP_AUTOCENTER` is off by default (which it > wasn't under Wine), doesn't check or set it, and so winds up with it on, or > * the kernel driver claims autocenter support but doesn't actually > support disabling it so it gets enabled (on the internal reset) and then > winds up stuck on despite being told to turn off (on the internal stop > all effects). > Of course, if either of these circumstances exist, this doesn't really > fix anything. It just shuffles the breakage between on and off. Hence > the italics. > My expectation is that this merge request originated out of the first of > these. That is easy to fix once verified (please run the test program!), > and I would be happy to put together a merge request for it. With regard > to the second, if such drivers exist, it a kernel driver bug and needs > to be fixed there (or, worst case, an if statement can be be added to > Wine to disable autocenter support under UDEV (input) and SDL for only > that device). Nothing is broken, the autocenter is just left to the drivers. The autocenter philosphy is very different on Linux vs windows where Setting an autocenter effect outside of the main program is a valid use-case. Linux doesn't even have a notion of acquiring FFB devices and you're free to send in effects from different. Yes, this change fixes the behavior of a lot of ffb devices for a lot of users, as can be seen here: https://github.com/ValveSoftware/Proton/issues/8395 Until we have a better Linux ffb api that's closer to the functionality of full PID protocol/dinput ffb api this is the best compromise. If you truly, really, just have to have autocenter on reset without using hidraw, please make an issue in the `hid-universal-pidff` development repository and we could upstream it. We're already tracking the number of effects and we could enable autocenter when there are none. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112532

1 0

Re: [PATCH v7 0/1] MR8605: winebus: Do not touch autocenter on device reset and stop all effects
by Tyson Whitehead (＠twhitehead) 08 Aug '25

08 Aug '25

On Fri Aug 8 12:08:40 2025 +0000, Rémi Bernon wrote: > The evdev and SDL backends suffer from impedence mismatch and they > cannot work identically to hidraw on every possible device. You should > use hidraw with your device, and every time it is supported, and evdev / > SDL for every other devices where it's not. > Then making sure evdev / SDL works best for devices without the hidraw > alternative is more important than making all the backends work > similarly for devices which can already be used with hidraw. Right. That makes sense. I don't think, however, that this merge request makes any devices work better. Instead I believe it just breaks `DIPROP_AUTOCENTER` support in a lot of cases. Specifically, wrt to devices that hidraw doesn't work (e.g., so UDEV (input) or SDL are the only option) I expect * all non-HID driver devices for which the kernel driver supported autocenter (e.g., the I-FORCE) are now broken wrt `DIPROP_AUTOCENTER` for all buses with respect to devices where hidraw wouldn't work with autocenter, but UDEV (input) or SDL would (e.g., devices that that don't turn autocenter on on reset and off on stop all effects) * all HID non-pidff driver devices for which the kernel driver support autocenter (e.g., the Logitech WingMan Force) are now broken wrt `DIPROP_AUTOCENTER` for all buses and with respect to devices where hidraw does work with autocenter (e.g., devices that do turn autocenter on on reset and off on stop all effects * all HID pdiff driver devices for which the kernel driver supported autocenter (e.g., the USB Sidewinder 2) are broken wrt `DIPROP_AUTOCENTER` for all buses but hidraw Unfortunately I don't have any of these devices to test apart for the USB Sidewinder 2 to prove this. The best I could do was to do was write a [test program](https://github.com/twhitehead/issue-wine-ff-autocenter) so people with them could check. It sounds like @TomaszPakula has some wheels to test. And perhaps @JacKeTUs has some non-HID devices to test too or knows someone who does? I would really appreciate it if everyone could test their device as, if I am correct, there is a lot of breakage here. The only two things I see it _fixing_ is when autocenter is desired to be off and * the program assumes `DIPROP_AUTOCENTER` is off by default (which it wasn't under Wine), doesn't check or set it, and so winds up with it on, * the kernel driver claims autocenter support but doesn't actually support disabling it so it gets enabled (on the internal reset) and then winds up stuck on despite being told to turn off (on the internal stop all effects). Of course, if either of these circumstances exist, this doesn't really fix anything. It just switches the breakage from permanently on to permanently off. Hence the italics. My expectation is that this merge request originated out of the first of these. That is easy to fix once verified (please run the test program!), and I would be happy to put together a merge request for it. With regard to the second, if such drivers exist, it a kernel driver bug and needs to be fixed there (or, worst case, an if statement can be be added to Wine to disable autocenter support under UDEV (input) and SDL only for only that device). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605#note_112517

1 0

[PATCH v4 0/4] MR8741: vccorlib140: Implement GetIidsFn and GetActivationFactoryByPCWSTR
by Vibhav Pant (＠vibhavp) 08 Aug '25

08 Aug '25

Required by WhatsApp Desktop. -- v4: vccorlib140: Implement GetIidsFn. vccorlib140: Add stub for GetIidsFn. vccorlib140: Implement GetActivationFactoryByPCWSTR. vccorlib140: Add stub for GetActivationFactoryByPCWSTR. https://gitlab.winehq.org/wine/wine/-/merge_requests/8741

3 6

[PATCH v2 0/2] MR8722: mf: Add a SUBMITTED command state to avoid multiple submission of the same op.
by Yuxuan Shui (＠yshui) 08 Aug '25

08 Aug '25

If a session is shutdown when its command_state is already COMPLETE, session_handle_source_shutdown calls session_set_stopped, which calls session_command_complete which will submit the op at the head of commands again, despite it having already been submitted. Given that only the op at the head of commands can be in the submitted state, tracking it as a command state makes more sense to me. And if the command state is SUBMITTED we know not to submit the op again. * * * Superceded !8270 -- v2: Apply 3 suggestion(s) to 1 file(s) https://gitlab.winehq.org/wine/wine/-/merge_requests/8722

2 2

[PATCH 0/1] MR8742: mf: Handle start request when session is already running.
by Bernhard Kölbl (＠besentv) 08 Aug '25

08 Aug '25

Starting the session while it's already running should not resume anything. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8742

2 1

[PATCH v3 0/4] MR8741: vccorlib140: Implement GetIidsFn and GetActivationFactoryByPCWSTR
by Vibhav Pant (＠vibhavp) 08 Aug '25

08 Aug '25

Required by WhatsApp Desktop. -- v3: vccorlib140: Implement GetIidsFn. vccorlib140: Add stub for GetIidsFn. vccorlib140: Implement GetActivationFactoryByPCWSTR. vccorlib140: Add stub for GetActivationFactoryByPCWSTR. https://gitlab.winehq.org/wine/wine/-/merge_requests/8741

3 11

[PATCH v4 0/8] MR8654: windows.devices.bluetooth: Add stubs for BluetoothLEAdvertisementWatcher
by Vibhav Pant (＠vibhavp) 08 Aug '25

08 Aug '25

`BluetoothLEAdvertisementWatcher` is required for LE device discovery on WinRT. Several WinRT apps, like Zwift will try getting this interface, and crash if they are not able to. -- v4: windows.devices.bluetooth: Implement BluetoothLEAdvertisementWatcher::get_{Min, Max}OutOfRangeTimeout. windows.devices.bluetooth: Implement BluetoothLEAdvertisementWatcher::get_{Min, Max}SamplingInterval. windows.devices.bluetooth: Add stubs for BluetoothLEAdvertisementWatcher. windows.devices.bluetooth/tests: Add tests for IBluetoothLEAdvertisementWatcher. windows.devices.bluetooth/tests: Add tests for BluetoothLEAdvertisementDataSection. windows.devices.bluetooth/tests: Add tests for IBluetoothLEAdvertisementBytePattern. windows.devices.bluetooth/tests: Add tests for BluetoothLEAdvertisementFilter. include: Add windows.devices.bluetooth.advertisement.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8654

3 15

[PATCH 0/8] MR8705: d3dx10: Exclusively use shared code to implement get_image_info().
by Connor McAdams (＠cmcadams) 08 Aug '25

08 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8705

3 18

[PATCH 0/4] MR8696: widl: Cleanup write_type helpers (1/3).
by Rémi Bernon (＠rbernon) 08 Aug '25

08 Aug '25

Patches taken from !6207, no-op but should make the `write_type` helpers more readable and flexible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8696

3 5

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Stian Low (＠stianlow) 08 Aug '25

08 Aug '25

See for latest updates regarding changes by this merge request: https://bugs.winehq.org/show_bug.cgi?id=58552 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_112475

1 0

2025

2024

2023

2022

wine-gitlab