On Tue Jan 31 17:20:28 2023 +0000, Aaron Hill wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/2059/diffs?diff_id=30165&start_sha=b2726ff2e1cf0e71d306e617a76f35503ea152bf#fb46240622c0bd2492f45d6d0dd17b8e3c4efa65_154_157)
I've adjusted this to use `I_RpcBindingInqLocalClientPID`, and removed the `process_id` parameter.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22495
On Mon Jan 30 12:30:54 2023 +0000, Huw Davies wrote:
> I think it would make sense to also test the `COINT_MULTITHREADED` case,
> perhaps by calling this function twice with a `flags` parameter. It
> would also make sense to split the tests off to a separate commit,
> before the implementation change, with appropriate `todo_wine`s which
> would get removed in the second commit.
I've added a `flags` parameter, and created a separate commit that adds the test with `todo_wines` in front of the `ok` check.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22494
Today, test_RtlUniform() skips almost all of its tests on Windows Vista
or later. The skipped tests only succeed in Windows XP, and fail on
Windows Vista or later.
This is because RtlUniform()'s behavior has changed, presumably due to a
bug fix shipped in Windows Vista. It appears that RtlUniform, a linear
congruential generator, could overflow before computing the modulo in
WindoWs XP. This is no longer the case in Windows Vista or later.
Meanwhile, we no longer support Windows XP behavior and thus do not test
for it regularly; therefore, the tests are obsolete as of 2023.
Remove obsolete tests that no longer work with any of the Windows
versions actively tested by WineHQ (as of 2023), and replace them with
updated tests that works in the Windows versions from Vista up to 10.
Also, fix Wine's RtlUniform() to match the new behavior accordingly.
--
v8: ntdll: Fix integer overflow in RtlUniform.
https://gitlab.winehq.org/wine/wine/-/merge_requests/821