- wine-gitlab - winehq.org

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 18 May '23

18 May '23

> Yes, Windows 10 v1803 ("April 2018 Update") was the first stable release of Windows to include this feature. `w1064v1507` fails, while `w1064v1809` passes. We'll need to account for that in the tests, by failing with win_skip() when we can't create an AF_UNIX socket. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33107

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 18 May '23

18 May '23

> @zfigura Can you elaborate on this? I don't see a clean way of doing this in ntdll without modifying `struct afd_bind_params`, `struct afd_connect_params`, etc. to add a field for the Unix path, since none of the other `sock_ioctl` cases add on varargs. afd_bind_params et al. should already take a variable sized sockaddr, and the struct definitions in include/wine/afd.h mention that specifically. Am I missing something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33106

1 0

[PATCH v2 0/1] MR2847: gdiplus: Improve performance of gdip_transform_points.
by Bartosz Kosiorek (＠gang65) 18 May '23

18 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53947 -- v2: gdiplus: Improve performance of gdip_transform_points. https://gitlab.winehq.org/wine/wine/-/merge_requests/2847

4 6

[PATCH v4 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.
by Sebastian Mayr (＠smayr) 18 May '23

18 May '23

This fixes the visual glitches and crashes of Worms Blast that were reported here: https://bugs.winehq.org/show_bug.cgi?id=54898 (and here: https://github.com/ValveSoftware/Proton/issues/706). There is, however, still an issue with the background music, which is not playing. -- v4: wined3d: Improve d3d8 compatibility of texture filters. https://gitlab.winehq.org/wine/wine/-/merge_requests/2821

3 3

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 18 May '23

18 May '23

Yes, Windows 10 v1803 ("April 2018 Update") was the first stable release of Windows to include this feature. `w1064v1507` fails, while `w1064v1809` passes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33095

1 0

Re: [PATCH v3 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.
by Stefan Dösinger (＠stefan) 18 May '23

18 May '23

Stefan Dösinger (@stefan) commented about dlls/d3d8/tests/device.c: > + BOOL has_texture; > + DWORD filters[7]; > + } > + tests[] = > + { > + { > + TRUE, > + { > + D3DTEXF_NONE, > + D3DTEXF_POINT, > + D3DTEXF_LINEAR, > + D3DTEXF_ANISOTROPIC, > + D3DTEXF_FLATCUBIC, > + D3DTEXF_GAUSSIANCUBIC, > + 0xdeadbeef, > + }, This feels awkward, the filter enum is the same in both cases. I think the test[] array can be removed entirely, or one filter[] array be used for both. (At which point tests[] becomes a relatively pointless array with TRUE and FALSE in it). I am not married to testing the value 0xdeadbeef, D3DTEXF_GAUSSIANCUBIC + 1 (6) would work just as well imo. That'd allow you to do for (mip = 0; mip <= D3DTEXF_GAUSSIANCUBIC + 1; ++mip). To answer your question re texture formats that can't be filtered: To my knowledge that doesn't exist in d3d8, and there is no equivalent to D3DUSAGE_QUERY_FILTER in d3d8 - this value is used to check for filtering capability in IDirect3D9::CheckDeviceFormat. Hypothetically, a volume texture could have different filter capabilities than a 2D texture. This seems to be the case even on my r200 - it supports mip filters (D3DPTFILTERCAPS_MIPFPOINT, D3DPTFILTERCAPS_MIPFLINEAR) for 2D, but not cube or 3D textures. I highly doubt that it complains about this in ValidateTexture though. I'll give it a try just in case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2821#note_33093

1 0

Re: [PATCH v3 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.
by Stefan Dösinger (＠stefan) 18 May '23

18 May '23

Stefan Dösinger (@stefan) commented about dlls/d3d8/device.c: > hr = wined3d_device_validate_device(device->wined3d_device, pass_count); > wined3d_mutex_unlock(); > > + /* In d3d8, texture filters are not validated, so errors concerning > + * unsupported ones are ignored here. */ > + if (hr == WINED3DERR_UNSUPPORTEDTEXTUREFILTER) { > + *pass_count = 1; > + return D3D_OK; > + } Two small requests here: Please follow the code style of the rest of the file (put the { on its own line), and print a WARN message, e.g. WARN("Ignoring invalid texture filter settings.\n"); -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2821#note_33092

1 0

[PATCH v2 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.
by Sebastian Mayr (＠smayr) 18 May '23

18 May '23

This fixes the visual glitches and crashes of Worms Blast that were reported here: https://bugs.winehq.org/show_bug.cgi?id=54898 (and here: https://github.com/ValveSoftware/Proton/issues/706). There is, however, still an issue with the background music, which is not playing. -- v2: wined3d: Improve d3d8 compatibility of texture filters. d3d8/tests: Test IDirect3DDevice8::ValidateDevice() with various min, mag and mip filters. https://gitlab.winehq.org/wine/wine/-/merge_requests/2821

4 3

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Loïc Rebmeister (＠Fox2Code) 18 May '23

18 May '23

It look like the windows version used for test doesn't support `AF_UNIX` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33081

1 0

Re: [PATCH v8 0/6] MR2786: Add support for AF_UNIX sockets
by Loïc Rebmeister (＠Fox2Code) 18 May '23

18 May '23

On Thu May 18 11:12:53 2023 +0000, Zebediah Figura wrote: > > "Unfortunately, last time I tried to write tests for Unix sockets, I > started triggering kernel panics in Windows." It seems like a Windows > specific issue! A kernel panic should never occur, even when provided > with invalid data. > Well... yes? I'm not sure what your point is. > > I think it's best to ignore Windows <-> Unix communications tests for > now as I don't think `winetest` allow running tests in both Windows and > Unix space at the same time, that would require `winetest` supporting > `wsl` when testing on Windows10+, and I think `wsl` support is out of > scope of this PR. > I'm not requesting tests for host interop here, and while I don't think > it's a bad idea (for some measure of stability) we don't have the > infrastructure to do those kinds of tests. "Well... yes? I'm not sure what your point is." It's just it made me laugh a bit that you made windows crash that easily by accident. I just pointed out the obvious cause I found it funny. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_33080

1 0

2025

2024

2023

2022

wine-gitlab