- wine-gitlab - winehq.org

[PATCH v4 0/8] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 16 May '23

16 May '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v4: ws2_32/tests: Add test for AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. ws2_32: Fix pointer arithmetic error in bind(). server: Fix pointer arithmetic error in sock_ioctl(). server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 10

[PATCH 0/1] MR2811: msvcrt/tests: Document why skip() is used for some missing APIs.
by Francois Gouget (＠fgouget) 16 May '23

16 May '23

Windows only provides the 32-bit API and using todo_wine win_skip() in the 64-bit case would imply Wine needs fixing. So it's simpler to use a plain skip(). Other schemes like picking between skip() and win_skip() based on bitness feel like they would be way overkill. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2811

3 2

[PATCH 0/1] MR2827: ntdll: Correctly identify hidden files
by David Kahurani (＠kahurani) 16 May '23

16 May '23

The code breaks as soon as we try to determine whether a path points to a directory. I suppose the changes will fix the issue. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54939 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2827

3 2

[PATCH v2 0/2] MR2809: user32/tests: Use win_skip() for missing APIs.
by Francois Gouget (＠fgouget) 16 May '23

16 May '23

A missing API is a todo in Wine. -- v2: uxtheme/tests: Use win_skip() for missing APIs. user32/tests: Use win_skip() for missing APIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2809

3 4

[PATCH 0/1] MR2825: dnsapi/tests: Ignore OPT records in the CNAME tests.
by Francois Gouget (＠fgouget) 16 May '23

16 May '23

This will hopefully fix the failures on Rémi's test machines: Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54848 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2825

2 1

[PATCH 0/6] MR2823: qcap: Audio capture filter implementation, part 3.
by Zebediah Figura (＠zfigura) 16 May '23

16 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2823

3 7

[PATCH 0/1] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) 15 May '23

15 May '23

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

7 15

[PATCH 0/5] MR2803: winegstreamer: Fix a few reference leaks and fix some misc issues found with Valgrind.
by Rémi Bernon (＠rbernon) 15 May '23

15 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2803

4 7

[PATCH 0/2] MR2815: winegstreamer: Fix IV50 video playback.
by Anton Baskanov (＠baskanov) 15 May '23

15 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2815

3 3

Re: [PATCH v2 0/4] MR2786: Add support for AF_UNIX sockets
by Zebediah Figura (＠zfigura) 15 May '23

15 May '23

On Mon May 15 21:29:55 2023 +0000, Zebediah Figura wrote: > It may also be worth pointing out, for anyone looking for ways to do > win32/unix interop using byte streams, that I believe it should already > be possible using FIFO devices (i.e. mkfifo) and normal read/write. > Granted, I haven't tested this, and maybe it's broken in some way or another? Or, for that matter, a TCP loopback socket :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_32822

1 0

2025

2024

2023

2022

wine-gitlab