- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR1783: msi: Fix memory leak on realloc failure in create_diff_row_query (cppcheck). - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1783

1 0

Re: [PATCH v2 0/1] MR1790: winspool: Improve the grammar of a comment in get_servername_from_name. - approved
by Alexandre Julliard (＠julliard) 25 Jan '23

25 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1790

1 0

[PATCH v2 0/1] MR1255: gitlab: Run win64 tests instead of wow64.
by Rémi Bernon (＠rbernon) 25 Jan '23

25 Jan '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1241. -- v2: gitlab: Run dinput 64-bit tests in a dedicated job. https://gitlab.winehq.org/wine/wine/-/merge_requests/1255

4 8

[PATCH v8 0/5] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v8: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface. windows.system.profile.systemmanufacturers: Add stub DLL. include: Add windows.system.profile.systemmanufacturers.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

3 7

[PATCH 0/1] MR2023: dplayx/tests: Skip tests when the dll is missing.
by Hans Leidekker (＠hans) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2023

3 2

Re: [PATCH v3 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

On Wed Jan 25 20:25:14 2023 +0000, Zebediah Figura wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/2010/diffs?diff_id=29048&start_sha=8eae0afb08c6e06634aa471605d9f9800d3144c8#0e3bdc3483a2521905df15e2af3431db3ab47a56_2279_2278) Wow, okay, thank you SPIR-V for the excellent choices in naming. Sent a v3 with this changed to 11.0, thanks :-) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010#note_21856

1 0

[PATCH v2 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

-- v2: wined3d: Disable 64-bit integer support. wined3d: Require shader cull distance support to create a feature level 10.0 device. wined3d: Require shader clip distance support to create a feature level 10.0 device. wined3d: Require gather offset support to create a feature level 10.1 device. wined3d: Require fragment shader image stores and atomics to create a feature level 10.0 device. https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

3 6

[PATCH 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 25 Jan '23

25 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

5 10

[PATCH v7 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 25 Jan '23

25 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v7: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH v2 0/6] MR1964: dxgi: Catch nested SetFullscreenState invocations.
by Stefan Dösinger (＠stefan) 25 Jan '23

25 Jan '23

FFXIV depends on this. It calls SetFullscreenState when it receives WM_WINDOWPOSCHANGED. Through luck the recursion aborts after two calls. The user-visible bug is that after leaving fullscreen, the game's window is still TOPMOST because we overwrite the stored pre-fullscreen window flags. -- v2: dxgi/tests: Test nested SetFullscreenState from the same thread. dxgi/tests: Test nested fullscreen application from different thread. dxgi: Catch nested SetFullscreenState invocations. dxgi/tests: Run test_swapchain_window_messages on d3d12. dxgi/tests: Run test_resize_target_wndproc on d3d12 too. dxgi/tests: Fix UnregisterClass call in test_resize_target_wndproc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1964

5 10

2025

2024

2023

2022

wine-gitlab