- wine-gitlab - winehq.org

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Loïc Rebmeister (＠Fox2Code) 14 May '23

14 May '23

On Sun May 14 11:59:45 2023 +0000, Loïc Rebmeister wrote: > `watcher_interface_name` is `org.kde.StatusNotifierItem` and this code > is only checking that. > Is this intentional that `org.freedesktop.StatusNotifierItem` is not checked? Nevermind I saw `org.freedesktop.StatusNotifierItem` used in the rest of the code and assumed it was already supported, but I checked commit names and saw it was intentional. I saw the rest of the code reference `org.freedesktop.StatusNotifierItem` A wine standard would be to remove the `org.freedesktop.StatusNotifierItem` from the KDE SNI Implementation commit, and then add the references back on the commit that add the `org.freedesktop.StatusNotifierItem` based implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808#note_32723

1 0

Re: [PATCH v4 0/2] MR2808: Draft: SNI tray implementation
by Loïc Rebmeister (＠Fox2Code) 14 May '23

14 May '23

Loïc Rebmeister (@Fox2Code) commented about dlls/winesni.drv/dbus.c: > + if (!(connection = p_dbus_bus_get_private( DBUS_BUS_SESSION, &error ))) { > + WARN("failed to get system dbus connection: %s\n", error.message ); > + p_dbus_error_free( &error ); > + goto err; > + } > + > + msg = p_dbus_message_new_method_call("org.freedesktop.DBus", > + "/org/freedesktop/DBus", > + "org.freedesktop.DBus", > + "GetNameOwner"); > + if (!msg) { > + goto err; > + } > + > + p_dbus_message_iter_init_append(msg, &args); > + if (!p_dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING, &watcher_interface_name )) { `watcher_interface_name` is `org.kde.StatusNotifierItem` and this code is only checking that. Is this intentional that `org.freedesktop.StatusNotifierItem` is not checked? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808#note_32722

1 0

[PATCH 0/1] MR2814: ntdll: calling virtual_free_teb when thread exit
by Fan WenJie (＠fanwenjie) 14 May '23

14 May '23

virtual_free_teb called on thread exit can save memory. pthread_create run start_thread_wrapper on a small size stack, start_thread_wrapper calls start_thread and switch on a big size thread stack. when thread exit, switch stack pointer return to the small size stack and free memory of the thread. Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2814

3 2

[PATCH v3 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v3: explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

[PATCH v2 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v2: explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

[PATCH 0/1] MR2813: ntdll/tests: Use win_skip() for missing APIs.
by Francois Gouget (＠fgouget) 13 May '23

13 May '23

A missing API is a todo in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2813

3 2

[PATCH 0/2] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 May '23

13 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

2 2

[PATCH v7 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) 13 May '23

13 May '23

Add the stub function D3DXComputeTangent based on the staging patch. https://bugs.winehq.org/show_bug.cgi?id=41697 Since this will at least make the application go further. Even though the implementation is based on documentation https://learn.microsoft.com/en-us/windows/win32/direct3d9/d3dxcomputetangent -- v7: d3dx9: Stub D3DXComputeTangent https://gitlab.winehq.org/wine/wine/-/merge_requests/2795

4 4

[PATCH 0/1] MR2807: msauddecmft: Add DllGetClassObject() stub.
by Mohamad Al-Jaf (＠maljaf) 13 May '23

13 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54934 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2807

2 1

[PATCH v8 0/11] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon (＠rbernon) 13 May '23

13 May '23

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v8: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

2 11

2025

2024

2023

2022

wine-gitlab