- wine-gitlab - winehq.org

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Zebediah Figura (＠zfigura) 01 May '23

01 May '23

> > > In practice I see a number of difficulties: > > > > > > * Shaders are not just code; they also embed interface information (input and output signatures, uniforms, buffers, object bindings, ...) and other random metadata (for example for the hull shaders). Should this be representable in the common IR? > > > > We need *some* way to represent that information so it doesn't get lost, at least. I think we don't want side channels, to be clear: I think that there should be a point where all of the information relevant to a shader is represented in v_s_i format, including metadata. > > > > And contrary to the instructions themselves, I think we want this information to be in a relatively simple and well-designed form. In a sense, it doesn't need to be "complex" like the instructions since we're not doing optimization passes over it \[if that makes sense\]. I think Conor has basically been pushing v_s_i in this direction in order to accommodate sm6 (at least wrt semantics), and given the tribulations I've had to endure to get sm1 to work, I think that's the right approach. > > Yes, although I don't think that necessarily means storing these as "instructions". The approach I'm personally leaning towards at this point is to rebrand "struct vkd3d_shader_instruction_array" as "struct vkd3d_shader_program" (or something along those lines), and then add the input/output/patch constant signatures and the shader version structure to that structure. I think a similar approach should work for e.g. RDEF as well. Yes, agreed wholeheartedly there. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31662

1 0

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Zebediah Figura (＠zfigura) 01 May '23

01 May '23

> This is causing several GStreamer-Video-CRITICAL messages to be printed while running the tests: Indeed. Looking into these might be a good idea, but on the other hand, if there's no actual regression in behaviour then I don't think we care. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546#note_31661

1 0

[PATCH 0/1] MR2728: gdiplus: Traverse and draw the whole string
by David Kahurani (＠kahurani) 01 May '23

01 May '23

There are a few things that are wrong with the handling of new lines in this code. However, this particular code pretty much stands out as being wrong, and fixing fixes the issue that the OP is talking about in the bug report. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45698 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2728

4 3

[PATCH 0/4] MR2731: Draft: Initial support for FILE_DISPOSITION_INFORMATION_EX
by Joel Holdsworth (＠jhol) 01 May '23

01 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2731

3 6

[PATCH v3 0/1] MR189: tests: Add a test for arrays with an expression as the index.
by Ethan Lee (＠flibitijibibo) 01 May '23

01 May '23

See https://bugs.winehq.org/show_bug.cgi?id=54832 I'm starting to see this particular FIXME in quite a few games (Escape Goat 2, Murder Miners, and Little Racers STREET to name a few), and since I'm not sure how to fix this I figured I could at least provide a test for someone that knows more SM4 than me :P -- v3: tests: Add a test for arrays with an expression as the index. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/189

4 3

[PATCH 0/8] MR2729: printing: Use EMF spool files while printing.
by Piotr Caban (＠piotr) 01 May '23

01 May '23

Also adds support for escapes writing to EMF spool file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2729

3 9

[PATCH v2 0/1] MR183: vkd3d-shader/hlsl: Always specify resource on intrinsic_tex().
by Francisco Casas (＠fcasas) 01 May '23

01 May '23

Otherwise, in the added test, we get: ``` vkd3d-compiler: vkd3d-shader/hlsl.c:452: hlsl_init_deref_from_index_chain: Assertion `chain' failed. ``` because on the path that triggers the following error: ``` E5002: Wrong type for argument 1 of 'tex3D': expected 'sampler' or 'sampler3D', but got 'sampler2D'. ``` a NULL params.resource is passed to hlsl_new_resource_load() and then to hlsl_init_deref_from_index_chain(). -- v2: vkd3d-shader/hlsl: Always specify resource on intrinsic_tex(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/183

5 4

[PATCH v12 0/2] MR178: vkd3d-shader/hlsl: Add support for sign() intrinsic.
by Ethan Lee (＠flibitijibibo) 01 May '23

01 May '23

This replicates what seems to be happening when using sign() with shader model 3, which is roughly... ``` int pos = (int) (x > 0); int neg = -((int) (x < 0)); int result = pos + neg; ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54826 -- v12: vkd3d-shader/hlsl: Add support for sign() intrinsic. tests: Add tests for sign() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/178

3 4

[PATCH 0/5] MR177: vkd3d-shader/hlsl: Normalize bools when loading from uniforms or vertex input.
by Zebediah Figura (＠zfigura) 01 May '23

01 May '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/177

5 13

[PATCH v10 0/13] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) 01 May '23

01 May '23

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v10: vkd3d-shader/hlsl: Consider duplicated input semantic types equivalent in SM1. vkd3d-shader/hlsl: Handle possibly different types in input semantic var load. vkd3d-shader/hlsl: Error out when a semantic is used with incompatible types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Support semantics for array types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

5 17

2025

2024

2023

2022

wine-gitlab