- wine-gitlab - winehq.org

[PATCH v4 0/1] MR1578: ntdll: TlsIndex should not actually contain tls indices
by Evan Tang (＠etang-cw) 08 Dec '22

08 Dec '22

> (The TlsIndex field in the LDR_DATA_TABLE_ENTRY structure appears to be unused except as a flag that the module has TLS (being always set to -1), at least as far back as Windows XP. It is worth mentioning that the WINE implementation of implicit TLS incorrectly uses TlsIndex as the real module TLS index, so it may be unreliable to assume that it is always -1 if you care about working on WINE.) > > \- http://www.nynaeve.net/?p=186 and the "links to that article but still doesn't work in wine" award goes to... [the D runtime](https://github.com/dlang/dmd/blob/6bf60ea0eb174631ede0074a77d3898d…! (Admittedly, there aren't too many ways to do what they're trying to do.) With this, the D runtime will now work in Wine, even if in a dll loaded into an exe with no tls (which gets it the tls index 0) The changes to the debugger are a bit icky, a possible alternative is to find some other easily-debugger-accessible place to stuff the tls index. -- v4: ntdll: TlsIndex should not actually contain tls indices https://gitlab.winehq.org/wine/wine/-/merge_requests/1578

4 3

[PATCH 0/1] MR1736: taskschd/tests: Fix test failures on newer version of Windows 10.
by Sven Baars (＠sbaars) 08 Dec '22

08 Dec '22

I created some new test failures yesterday, sorry for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1736

4 5

[PATCH v2 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 08 Dec '22

08 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v2: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 17

[PATCH 0/1] MR1741: winhttp/tests: Reduce send buffer size.
by Hans Leidekker (＠hans) 08 Dec '22

08 Dec '22

It looks like there was a change on the websocket test server that causes our send operations to block. Reducing the size of the send buffer works around the test failures. The tests still succeed on Windows, which suggests that native sends large buffers in smaller chunks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1741

2 1

[PATCH 0/3] MR1740: Enable long types in wined3d/arb_program_shader.c
by eric pouech (＠epo) 08 Dec '22

08 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1740

2 3

[PATCH 0/1] MR1545: Draft: rpcrt4: Fix GCC12.2 warnings.
by eric pouech (＠epo) 08 Dec '22

08 Dec '22

GCC12.2 warns about dereferencing a pointer to RpcPktHdr while it has been allocated to the size of one of the packet (hence smaller in some cases). /home/eric/work/wine/dlls/rpcrt4/rpc_message.c:111:26: warning: array subscript 'RpcPktHdr[0]' is partly outside array bounds of 'unsigned char[24]' [-Warray-bounds] 111 | Header->common.rpc_ver = RPC_VER_MAJOR; This patch fixes the warnings by accessing the created object through a pointer to their type (and not through the union). Notes: - the 'max(sizeof(...), FIELD_OFFSET(...))' thingie in RPCRT4_BuildBindNackHeader avoids also a warning as the FIELD_OFFSET() can be smaller than the size of the structure. This could be avoided by using a flexible array member for the 'protocols' field instead of 'protocols[ANYSIZE_ARRAY]'. - I only changed the allocation routines when the allocated size is smaller than the union. If the strategy is validated, one could consider applying the same allocation strategy to all helpers for symmetry reasons. Hence the draft status for now, waiting for feedback. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1545

3 4

[PATCH v2 0/1] MR1721: cmd: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 08 Dec '22

08 Dec '22

-- v2: cmd: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1721

2 1

[PATCH 0/1] MR1721: cmd: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 08 Dec '22

08 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1721

4 6

[PATCH 0/1] MR1735: include: Add corecrt_malloc.h.
by Alex Henrie (＠alexhenrie) 08 Dec '22

08 Dec '22

This removes the duplication between malloc.h and stdlib.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1735

2 1

[PATCH v4 0/2] MR1686: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _strdup, _wcsdup, _aligned_malloc
by Brendan Shanks (＠bshanks) 08 Dec '22

08 Dec '22

-- v4: include/msvcrt: Add __WINE_(ALLOC_SIZE|DEALLOC|MALLOC) attributes to _aligned_malloc functions. include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. https://gitlab.winehq.org/wine/wine/-/merge_requests/1686

3 4

2025

2024

2023

2022

wine-gitlab