- wine-gitlab - winehq.org

[PATCH v5 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 03 Dec '22

03 Dec '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v5: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

5 10

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Alexandre Julliard (＠julliard) 03 Dec '22

03 Dec '22

> * direct call: 5761 > * unpatched Wine: 13933 > * ret.diff: 6823 (55% time spent in \__wine_unix_call_dispatcher, 29% in PE vkGetPhysicalDeviceProperties) > > Looks impressive! Thanks, committed as 0aae4b05633cb9b38eb37cc662f5a3aadb3ce108. Can we get rid of direct calls now? :wink: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18536

1 0

Re: [PATCH v3 0/5] MR1622: d3d10/effect: Add support for more instructions. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1622

1 0

Re: [PATCH v6 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

1 0

Re: [PATCH v2 0/1] MR1654: mfplat: Clear the clsid pointer in MFTEnum to avoid invalid free. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1654

1 0

[PATCH v7 0/2] MR1618: gdiplus: improve performance of GdipScaleMatrix
by Bartosz Kosiorek (＠gang65) 02 Dec '22

02 Dec '22

-- v7: gdiplus: improve performance of matrix multiplication by unrolling loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1618

4 10

Re: [PATCH v3 0/8] MR1659: localspl: Add support for Job handles. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1659

1 0

Re: [PATCH v2 0/1] MR1623: rpcrt4/tests: Don't use an array of pointers in test_conf_complex_struct. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1623

1 0

Re: [PATCH v2 0/1] MR1653: msvcrt: Use operator_delete to free _Condition_variable queue nodes. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1653

1 0

Re: [PATCH v2 0/1] MR1640: mshtml: Fix realloc size vs element count mixup. - approved
by Alexandre Julliard (＠julliard) 02 Dec '22

02 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1640

1 0

2025

2024

2023

2022

wine-gitlab