- wine-gitlab - winehq.org

[PATCH 0/1] MR1627: winevulkan: Fix handling pointers to pointer-size variables in 32-bit thunks.
by Jacek Caban (＠jacek) 01 Dec '22

01 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1627

3 2

[PATCH v2 0/2] MR1559: ntoskrnl.exe: Prevent blocking if kernel timer is reset in DPC.
by Ivo Ivanov (＠logos128) 01 Dec '22

01 Dec '22

KeCancelTimer (which is called via KeSetTimerEx) would block indefinitely in the DPC, while waiting for the timer to complete. Which never happens, since the internal thread pool implementation never gets the chance to wake up the "finished_event" condition variable on the DPC exit in tp_object_execute(). -- v2: ntoskrnl.exe/tests: Test resetting a kernel timer in its DPC. ntoskrnl.exe: Prevent blocking if timer is reset in DPC. https://gitlab.winehq.org/wine/wine/-/merge_requests/1559

2 2

[PATCH v3 0/6] MR1588: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 01 Dec '22

01 Dec '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v3: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. wbemprox: Provide accurate SMBIOS serial number. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

4 14

[PATCH 0/1] MR1626: kernelbase: Workaround for linux-side redirection.
by xantares (＠xantares) 01 Dec '22

01 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 ``` 1016195.340:0114:0118:Call KERNEL32.GetFileType(00000014) ret=1022e621 1016195.340:0114:0118:Call ntdll.NtQueryVolumeInformationFile(00000014,0060f598,0060f590,00000008,00000004) ret=7b01f4a5 1016195.340:0114:0118:Ret ntdll.NtQueryVolumeInformationFile() retval=00000000 ret=7b01f4a5 1016195.340:0114:0118:Ret KERNEL32.GetFileType() retval=00000001 ret=1022e621 1016195.340:0114:0118:Call KERNEL32.GetFileInformationByHandle(00000014,0060f608) ret=1022e6ac 1016195.340:0114:0118:Call ntdll.NtQueryInformationFile(00000014,0060f508,0060f528,00000068,00000012) ret=7b01eacc 1016195.340:0114:0118:trace:file:NtQueryInformationFile (0x14,0x60f508,0x60f528,0x00000068,0x00000012) 1016195.340:0114:0118:Ret ntdll.NtQueryInformationFile() retval=c0000024 ret=7b01eacc 1016195.340:0114:0118:Call ntdll.RtlNtStatusToDosError(c0000024) ret=7b01eae3 1016195.340:0114:0118:Ret ntdll.RtlNtStatusToDosError() retval=00000006 ret=7b01eae3 1016195.340:0114:0118:Ret KERNEL32.GetFileInformationByHandle() retval=00000000 ret=1022e6ac ``` Allocation of the fd structure, fd->unix_name is set to NULL: ``` 1697 fd->unix_name = NULL; #0 alloc_fd_object () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:1697 #1 0x000056259dd386d8 in create_anonymous_fd (fd_user_ops=fd_user_ops@entry=0x56259dda4900 <file_fd_ops>, unix_fd=unix_fd@entry=28, user=user@entry=0x56259f42db70, options=options@entry=32) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2074 #2 0x000056259dd3b477 in create_file_for_fd (fd=28, access=1074790400, sharing=sharing@entry=3) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:152 #3 0x000056259dd3b874 in req_alloc_file_handle (req=0x56259f27b768, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/file.c:730 #4 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f27b620) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ``` Because unix_name is not set no file information get returned: ``` 2780 if (fd->unix_name) #0 req_get_handle_unix_name (req=<optimized out>, reply=0x7ffc518872e0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/fd.c:2780 #1 0x000056259dd594b3 in call_req_handler (thread=thread@entry=0x56259f432020) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/server/request.c:309 ... #0 wine_server_call (req_ptr=0x62fac0) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/server.c:286 #1 0xf7b98514 in server_get_unix_name (handle=handle@entry=0x14, unix_name=unix_name@entry=0x62fb94) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:1776 #2 0xf7ba3b1f in NtQueryInformationFile (handle=0x14, io=0x60f568, ptr=0x60f588, len=104, class=FileAllInformation) at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/file.c:4177 #3 0xf7bbd679 in __wine_syscall_dispatcher () at /home/bernhard/data/entwicklung/2021/wine/wine-git/wine-git/dlls/ntdll/unix/signal_i386.c:153 ... ``` https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… https://github.com/python/cpython/blob/99fcf1505218464c489d419d4500f126b6d6… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1626

3 3

[PATCH 0/1] MR1624: include: Define __stat64.
by Alex Henrie (＠alexhenrie) 01 Dec '22

01 Dec '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1624

3 2

[PATCH v2 0/1] MR1510: winebus.sys: Use the device path instead of the udev_device pointer to match devices.
by Zebediah Figura (＠zfigura) 01 Dec '22

01 Dec '22

The latter is not guaranteed to be equal across events, and in practice may not be. -- v2: winebus.sys: Search for added devices by devnode path in process_monitor_event(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1510

3 4

[PATCH v2 0/5] MR1608: localspl: Use providor for print jobs implementation
by Piotr Caban (＠piotr) 01 Dec '22

01 Dec '22

-- v2: winspool: Use providor for WritePrinter implementation. winspool: Use providor for print jobs implementation. localspl: Fix error handling in ScheduleJob. localspl: Return error if cups port handle is used from different threads. localspl: Add cups port extension. https://gitlab.winehq.org/wine/wine/-/merge_requests/1608

2 6

Re: [PATCH v5 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 01 Dec '22

01 Dec '22

thanks for the help @piotr -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1553#note_18209

1 0

[PATCH v3 0/3] MR1542: winegstreamer: Get MF_SD_LANGUAGE and (for QT demuxer only) MF_SD_STREAM_NAME.
by Paul Gofman (＠gofman) 01 Dec '22

01 Dec '22

-- v3: mfplay/tests: Add MF_SD_LANGUAGE and MF_SD_STREAM_NAME value tests. winegstreamer: Extract stream name from QT demuxer private data. winegstreamer: Query stream tags and set MF_SD_LANGUAGE attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/1542

4 6

Re: [PATCH v13 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 01 Dec '22

01 Dec '22

On Wed Nov 30 14:42:28 2022 +0000, Jason Kuo wrote: > Oops, didn't noticed that, will fix in next version. Moved the changes to first commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1268#note_18195

1 0

2025

2024

2023

2022

wine-gitlab