- wine-gitlab - winehq.org

[PATCH 0/1] MR2597: advapi32: Print ReportEvent() messages one line at a time.
by Zebediah Figura (＠zfigura) 06 Apr '23

06 Apr '23

.NET Framework passes multiline backtraces to ReportEvent(), which get cut off when passed to debugstr_w(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2597

2 1

[PATCH v3 0/2] MR2593: Draft: winex11.drv: UpdateDisplayDevice regression fixes
by Alexandros Frantzis (＠afrantzis) 06 Apr '23

06 Apr '23

This MR contains two somewhat related commits/fixes for regressions that were made apparent in https://bugs.winehq.org/show_bug.cgi?id=54781. 1. The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). 2. The virtual desktop get_current_mode() implementation recurses into win32u (through NtUserGetPrimaryScreenRect) causing a deadlock if we call it from within UpdateDisplayDevices. There is a way to avoid the deadlock if we get the current_modes before calling add_gpu(), but we don't need to get and update the win32u current/registry in the virtual desktop case anyway, so skip the call completely instead. -- v3: winex11.drv: Do not call desktop get_current_mode() from UpdateDisplayDevices. winex11.drv: Use the proper id with the settings handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

4 5

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) 06 Apr '23

06 Apr '23

Hi Yeshun, you don't need to regularly rebase the MR on top of the latest master. Because this area of code is largely undocumented, to help this MR gets in, you need to add a test, even if it might not be easy. I think you can use some of the example codes in NCALRPC_example. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29113

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. - closed
by Alex Henrie (＠alexhenrie) 06 Apr '23

06 Apr '23

This merge request was closed by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) 06 Apr '23

06 Apr '23

On Tue Apr 4 19:02:38 2023 +0000, Zebediah Figura wrote: > It's hard for me to feel like this is an improvement, when we are now > adding an extra parameter to every call, and also using some > undocumented Windows functions that, to the reader, might have some > obscure different semantics. Based on that feedback, I am closing this merge request in favor of !2590, which at least gets rid of the duplicate implementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_29106

1 0

[PATCH v5 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) 06 Apr '23

06 Apr '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v5: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

2 2

[PATCH 0/1] MR2553: win32u: Add➕ emoji💯🤣👀 to message✉️.c.
by Zebediah Figura (＠zfigura) 06 Apr '23

06 Apr '23

Emoji👌🔥 reflect modern communication🗣️ practices, they'll make Wine🍷 more accessible♿ to young🧒 hackers💻, and they make code⌨️ easier to read📚. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2553

9 12

[PATCH 0/7] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) 06 Apr '23

06 Apr '23

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

3 13

Re: [PATCH v2 0/12] MR2589: msvcrt: Use a few more functions from the bundled musl library. - approved
by Alexandre Julliard (＠julliard) 05 Apr '23

05 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2589

1 0

Re: [PATCH v2 0/4] MR2586: quartz/vmr9: Clean up IVMRFilterConfig9::SetRenderingMode(). - approved
by Alexandre Julliard (＠julliard) 05 Apr '23

05 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2586

1 0

2025

2024

2023

2022

wine-gitlab