- wine-gitlab - winehq.org

[PATCH 0/3] MR1549: configure: Clang build fixes.
by Jacek Caban (＠jacek) 25 Nov '22

25 Nov '22

I recently noticed problems with building with clang in msvc mode when using my distro clang. It seems specific to its configuration, I think that it doesn't affect default clang. One problem is that --rtlib=libgcc is specified in /etc/clang, which causes clang to produce: ``` clang-15: error: unsupported runtime library 'libgcc' for platform 'MSVC' ``` I think it's a clang bug here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/… It should probably check for -nodefaultlibs in addition to -nostdlib. It's easy to handle on Wine side by using -nostdlib. The other problem is that clang for some reason doesn't define `_MSV_VER` by default. I found that it's defined only if I pass `-fuse-ld=lld` to the command line. That's weird because it shouldn't affect compilation step, it should matter only for linking and that's when we pass it. I didn't track it down in clang code itself, but if we can't depend on clang providing it by default, we need to make sure to pass `-fms-compatibility-version` ourselves. The exact version doesn't really matter, we mostly need to make sure that it's defined at all so that our #ifdefs work correctly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1549

4 9

[PATCH v5 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) 25 Nov '22

25 Nov '22

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default properties but this does not appear to be the case. I guess there's no reason to keep the checks for each member of the computed color struct? Perhaps keep the checks for E_INVALIDARG and S_OK? I haven't come across an application that uses the functions so I didn't implement them. For the rest of the properties, the if (0) test was added just to show that it crashes with a NULL value. Also, if the wrong type is passed, the function does not crash on Windows and the value remains unchanged, but it returns S_OK. -- v5: windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontEffect. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontStyle. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontSize. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontColor. windows.media/tests: Add Closed Caption Properties tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

5 18

[PATCH 0/2] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 25 Nov '22

25 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 5

[PATCH v2 0/11] MR1526: mshtml: Misc improvements.
by Gabriel Ivăncescu (＠insn) 25 Nov '22

25 Nov '22

For the `performance.navigation` props, I store them in the timing that's already linked from the window, to prevent adding more code around that just for 2 props, so it keeps it simple. -- v2: include/mshtml: Add IHTMLXDomainRequest and factory interfaces and classes. mshtml: Don't check for doc_node from the doc obj when it can't be NULL. mshtml: Return proper error for invalid selectors in IE8 mode. mshtml: Treat edit mode as a reload. mshtml: Implement performance.navigation.type. mshtml: Implement performance.navigation.redirectCount. mshtml: Set `reload` load type to Gecko for document reloads. mshtml: Implement `onload` prop for input elements. mshtml: Send load event synchronously for image elements if set to same src. mshtml: Implement location.reload(). mshtml: Implement print events. https://gitlab.winehq.org/wine/wine/-/merge_requests/1526

4 18

[PATCH v2 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- v2: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

4 7

[PATCH v3 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- v3: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

3 4

[PATCH 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

2 3

[PATCH 0/6] MR1548: ntdll: Relax heap locking to access block information.
by Rémi Bernon (＠rbernon) 25 Nov '22

25 Nov '22

We are currently locking the heap to iterate over the allocated regions, in order to check whether a pointer / block really belongs to one of them. This is not what native does it, as HeapFree / HeapReAlloc / HeapSize crashing on invalid pointers shows. This also makes it hard to improve the heap performance in multi-threaded scenarios. This series reduces the locking requirement by keeping the region header offset in each block, relaxing the pointer checks, and assuming a heap region stays valid until all of its blocks have been freed. This also removes the locking requirement when accessing block level information, such as block type or flags or block user info. I'm assuming here that concurrent calls to heap functions on a given block are undefined. Anything that involves modifying the block size, type or flags, walking the heap, or explicit validation still requires entering the heap lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1548

2 6

[PATCH v2 0/1] MR1519: mshtml: Handle memory allocation failure in ConnectionPoint_Advise.
by Alex Henrie (＠alexhenrie) 25 Nov '22

25 Nov '22

-- v2: mshtml: Handle memory allocation failure in ConnectionPoint_Advise. https://gitlab.winehq.org/wine/wine/-/merge_requests/1519

3 2

[PATCH 0/1] MR1544: wininet: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 25 Nov '22

25 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1544

3 2

2025

2024

2023

2022

wine-gitlab