- wine-gitlab - winehq.org

Re: [PATCH v2 0/11] MR2522: wineps: Add support for more spool file records - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

1 0

Re: [PATCH v6 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

1 0

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

1 0

Re: [PATCH v2 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

1 0

Re: [PATCH v2 0/6] MR2518: Fixes and improvements for taskschd:scheduler - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

1 0

Re: [PATCH v3 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag. - approved
by Alexandre Julliard (＠julliard) 28 Mar '23

28 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

1 0

[PATCH 0/1] MR2525: wip
by Rémi Bernon (＠rbernon) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2525

2 3

[PATCH 0/4] MR2523: uiautomationcore: Miscellaneous MSAA provider patches.
by Connor McAdams (＠cmcadams) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2523

4 6

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

I left a few comments on the tests. Otherwise, I quite like the patch series. Force-setting the extended attributes on visible-but-starting-with-a-dot files seems like a good compromise to fix the bug at hand without requiring a ton of attribute setting and I couldn't think of any better solution. This won't fix the case of Wine-created dot files when the show_dot_files option is enabled if the user then disables the option, which again seems like a good compromise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28247

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) 28 Mar '23

28 Mar '23

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; > + > + GetTempFileNameW( temppathW, L".foo", 0, filenameW ); > + if (!rename_file( h, filenameW )) return; ```suggestion:-0+0 winetest_push_context("foo -> .foo"); rename_file( h, filenameW ); winetest_pop_context(); ``` Or something like that. Similarly for the other rename_file() call below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28246

1 0

2025

2024

2023

2022

wine-gitlab