- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR2827: ntdll: Correctly identify hidden files
by David Kahurani (＠kahurani) 16 May '23

16 May '23

On Tue May 16 12:34:25 2023 +0000, Sven Baars wrote: > This line and the following line should probably be combined into one to > fix the issue. Yeah, I noticed that my changes alienate directories which should be part of the "dot files" but I think I have come across a different problem that might be harder to solve. The tests don't seem to like these changes.... ``` GetTempPathA( MAX_PATH, temppath ); GetTempFileNameA( temppath, ".foo", 0, filename ); h = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); status = nt_get_file_attrs(filename, &attrs); ok( status == STATUS_SUCCESS, "got %#lx\n", status ); ok( !(attrs & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", attrs ); ``` This test creates a temporary file(hidden as per its unix path but of course not hidden as per Windows functioning). The test expects that the file is not hidden but our changes make it so that the file is reported as hidden. I suspect the old code was carefully crafted so as to avoid marking a file as hidden unless it is absolutely necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2827#note_32883

1 0

Re: [PATCH v2 0/1] MR2827: ntdll: Correctly identify hidden files
by Sven Baars (＠sbaars) 16 May '23

16 May '23

Sven Baars (@sbaars) commented about dlls/ntdll/unix/file.c: > * Check if the specified file should be hidden based on its unix path and the show dot files option. > */ > -static BOOL is_hidden_file( const char *name ) > +static BOOL is_hidden_file( const char *path ) > { > const char *p; > + struct stat st; > > if (show_dot_files) return FALSE; > > - p = name + strlen( name ); > - while (p > name && p[-1] == '/') p--; > - while (p > name && p[-1] != '/') p--; > - if (*p++ != '.') return FALSE; > - if (!*p || *p == '/') return FALSE; /* "." directory */ > - if (*p++ != '.') return FALSE; This line and the following line should probably be combined into one to fix the issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2827#note_32881

1 0

[PATCH 0/1] MR2829: dinput/tests: Add a zero-terminator for hardware ids (Valgrind).
by Rémi Bernon (＠rbernon) 16 May '23

16 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2829

2 1

[PATCH 0/2] MR2752: combase: Prevent use-after-free due to a race with proxy_manager_destroy.
by Jinoh Kang (＠iamahuman) 16 May '23

16 May '23

Today, find_proxy_manager() may return a proxy manager that is about to be freed. This happens when the proxy manager's reference count reaches zero, but proxy_manager_destroy() has not removed the proxy manager from the apartment proxy list. Fix this by only incrementing the reference count if it was nonzero. If the reference count is zero, proxy_manager_destroy() will proceed to destroy the proxy manager after the current thread releases the apartment lock (apt->cs). Granted, this is fragile is far from elegant, but it seems like a safe approach for the time being. Also, the critical section and "safe" refcount increment will prevent the following race condition scenario: > 1. Thread X: A proxy manager's refcount reaches 0 and is about to be released. > 2. Thread Y tries to grab it, calls AddRef, notices it returns 1, and drops it. > 3. Thread Z tries to grab it, calls AddRef, notices it returns 2, and returns it. > 4. Thread X then proceeds to remove it from the list and free the object. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2752

4 6

[PATCH 0/4] MR2824: wine{alsa,coreaudio,oss,pulse}: Move AudioRenderClient into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 16 May '23

16 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2824

3 5

Re: [PATCH v2 0/1] MR2827: ntdll: Correctly identify hidden files
by David Kahurani (＠kahurani) 16 May '23

16 May '23

On Tue May 16 07:36:20 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=132716 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > file.c:4097: Test failed: got attributes 0x22 > === debian11 (32 bit zh:CN report) === > ntdll: > file.c:4097: Test failed: got attributes 0x22 > === debian11b (64 bit WoW report) === > ntdll: > file.c:4097: Test failed: got attributes 0x22 > ``` It looks to me like the only way around this would be to treat prefixes separately from other paths but it is not clear to me how one would positively identify a path that lies within a prefix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2827#note_32872

1 0

[PATCH 0/3] MR2804: rtworkq: Fix some reference leaks found with Valgrind.
by Rémi Bernon (＠rbernon) 16 May '23

16 May '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2804

3 4

[PATCH 0/7] MR2828: wineps: Support loading builtin font information from NTF files.
by Piotr Caban (＠piotr) 16 May '23

16 May '23

The real motivation for the patches is to stop using PRINTERINFO structure in unixlib. I was planning to move AFM handling to unixlib initially but it depends on string to float parsing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2828

3 8

[PATCH v7 0/7] MR193: vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations.
by Nikolay Sivov (＠nsivov) 16 May '23

16 May '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v7: tests: Add RWBuffer writing test. tests: Add support for UAV buffers to d3d12 runner. tests: Add support for UAV buffers in Vulkan runner. vkd3d-shader/hlsl: Improve UAV format type checking for buffer types. vkd3d-shader/hlsl: Add support for writing RWStructuredBuffer declarations. vkd3d-shader/hlsl: Add support for RWBuffer object. vkd3d-shader: Fix dcl_uav_typed_* formatting. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/193

3 14

[PATCH v4 0/8] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 16 May '23

16 May '23

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v4: ws2_32/tests: Add test for AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. ws2_32: Fix pointer arithmetic error in bind(). server: Fix pointer arithmetic error in sock_ioctl(). server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 10

2025

2024

2023

2022

wine-gitlab