--
v6: winecoreaudio: Switch to mmdevapi's unixlib.h.
winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's.
winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's.
winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead.
mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
winecoreaudio: Switch to string as device identifier, to match other drivers.
https://gitlab.winehq.org/wine/wine/-/merge_requests/813
It's not exactly clear to me why gcc warns about this (and it's hard to find
reference for this specific flavor of -Waddress), but my understanding is that
arithmetic on well-defined pointers will never yield NULL. Of course, we are not
dealing with well-defined pointers here, but fortunately gcc does not complain
if we cast to intptr_t first.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/868
--
v5: winecoreaudio: Switch to mmdevapi's unixlib.h.
winecoreaudio: Adapt "get_capture_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_render_buffer_params" struct to mmdevapi's.
winecoreaudio: Adapt "release_stream_params" struct to mmdevapi's.
winecoreaudio: Adapt "create_stream_params" struct to mmdevapi's.
winecoreaudio: Drop "unix_" prefix in unixlib enum, apply it to the functions instead.
mmdevapi: Integrate winecoreaudio's additions in unixlib.h.
winecoreaudio: Switch to string as device identifier, to match other drivers.
https://gitlab.winehq.org/wine/wine/-/merge_requests/813
On Fri Sep 16 02:11:42 2022 +0000, Huw Davies wrote:
> Looks like the app calls `WinUsb_Free(NULL)` on startup.
Thank you so much for the review! Yeah, it's quite strange that it calls it with a NULL parameter. What is the purpose of it?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/827#note_8654