- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR2060: po: Update Tamil translation - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2060

1 0

[PATCH v5 0/1] MR1977: comctl32: Fix PathWordBreakProc.
by Vladislav Timonin (＠vt) 30 Jan '23

30 Jan '23

Currently it doesn't work as expected, namely gets stuck on delimiter and caret is moved before the delimiter. Unnecessary more robust than Windows, which feels like doesn't do any checks at all. EDIT1: v2: return length in `WB_RIGHT` if its bigger than default return value of 0 on invalid values EDIT2: v3: don't test `WB_ISDELIMITER` with out of bounds indices, Windows doesn't check them and does out of bounds reads -- v5: comctl32: Fix PathWordBreakProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/1977

2 4

Re: [PATCH v2 0/2] MR2058: winex11: Make some definitions hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2058

1 0

Re: [PATCH v3 0/2] MR2055: win32u: Make more definitions hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2055

1 0

Re: [PATCH v2 0/5] MR2056: ntdll: Make some definitions static or hidden. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2056

1 0

Re: [PATCH v2 0/1] MR2050: include: Remove __WINE_MALLOC from functions that shouldn't have it. - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2050

1 0

Re: [PATCH v2 0/1] MR2052: tools: Include limits.h for PATH_MAX - approved
by Alexandre Julliard (＠julliard) 30 Jan '23

30 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2052

1 0

[PATCH 0/1] MR74: vkd3d-shader/hlsl: Support dot() for SM1.
by Nikolay Sivov (＠nsivov) 30 Jan '23

30 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/74

6 15

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

There is another things that bothers me: The while loop in parse_wave_form(): - WAVE file chunk order is fmt and then data - The last fmt or data chunk will "win"; doubt there are any dmusic related WAVE files with duplicate fmt or data chunks. But for now we can start with the while() loop: - No clue where those extra chunks are placed - We don't do anything with the WAV file; we just store it. Though we might run into memory issues with big WAV files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22349

1 0

Re: [PATCH v2 0/1] MR2029: dmime: Store WAVE data when Loading.
by Michael Stefaniuc (＠mstefani) 30 Jan '23

30 Jan '23

Michael Stefaniuc (@mstefani) commented about dlls/dmime/segment.c: > + case FOURCC_LIST: { > + FIXME("Skipping LIST tag\n"); > + break; > + } > + case mmioFOURCC('I','S','F','T'): { > + FIXME("Skipping ISFT tag\n"); > + break; > + } > + case mmioFOURCC('f','a','c','t'): { > + FIXME("Skipping fact tag\n"); > + break; > + } > + } > + } > + > + return S_OK; The stream_next_chunk() in the while loop can fail too and you'll need to return that failure too. S_FALSE indicates "no more chunks". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2029#note_22348

1 0

2025

2024

2023

2022

wine-gitlab