- wine-gitlab - winehq.org

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) 29 Jul '22

29 Jul '22

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + res = SendMessageA(hwnd, WM_KEYDOWN, VK_DOWN, 0); > + expect(0, res); > + ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > + ownerdata_multiselect_select_3_odstatechanged_seq, > + "ownerdata multiselect: deselect all, select item 3 via DOWN", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > + > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* First up then down */ > + /* Select multiple items via SHIFT+UP */ For consistency, let's move hold_key() to the start of each test. Right now some of them are at the start and some are at the up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5316

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) 29 Jul '22

29 Jul '22

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c: > > - /* disable per item notifications on LVS_OWNERDATA style > - FIXME: single LVN_ODSTATECHANGED should be used */ > + /* Disable per item notifications on LVS_OWNERDATA style */ > old_mask = infoPtr->notify_mask & NOTIFY_MASK_ITEM_CHANGE; > if (infoPtr->dwStyle & LVS_OWNERDATA) > infoPtr->notify_mask &= ~NOTIFY_MASK_ITEM_CHANGE; > > LISTVIEW_DeselectAllSkipItems(infoPtr, selection); > > - > iterator_rangesitems(&i, selection); > while(iterator_next(&i)) > - LISTVIEW_SetItemState(infoPtr, i.nItem, &item); > + { > + // Find the range for LVN_ODSTATECHANGED Please use /**/ instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5315

1 0

Re: [PATCH v2 0/1] MR558: win32u: Fix typo in font handle creation in NtUserDrawCaptionTemp(). - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/558

1 0

Re: [PATCH v2 0/5] MR552: win32u: Simplify and move rawinput registration logic to the client side. - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/552

1 0

Re: [PATCH v2 0/3] MR556: mshtml: Basic implementation of XMLHttpRequest response method. - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/556

1 0

Re: [PATCH v2 0/2] MR554: regedit: More REG_DWORD / REG_QWORD dialog fixes - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/554

1 0

Re: [PATCH v2 0/6] MR555: win32u: user32 separation - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/555

1 0

Re: [PATCH v2 0/3] MR537: riched20: Ensure that cursor is visible when selecting text. - approved
by Alexandre Julliard (＠julliard) 28 Jul '22

28 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/537

1 0

[PATCH 0/1] MR558: win32u: Fix typo in font handle creation in NtUserDrawCaptionTemp().
by Nikolay Sivov (＠nsivov) 28 Jul '22

28 Jul '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/558

2 1

[PATCH 0/5] MR553: mf: Some attribute tweaks to fix Resampler transform regressions.
by Rémi Bernon (＠rbernon) 28 Jul '22

28 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/553

3 7

2025

2024

2023

2022

wine-gitlab