- wine-gitlab - winehq.org

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/effect.c: > - if (effect->params.count) > + if (FAILED(hr = d3dx_init_parameters_store(&effect->params, params_count))) > { > - effect->params.parameters = heap_alloc_zero(sizeof(*effect->params.parameters) * effect->params.count); > - if (!effect->params.parameters) > - { > - ERR("Out of memory.\n"); > - hr = E_OUTOFMEMORY; > - goto err_out; > - } > + hr = E_OUTOFMEMORY; > + goto err_out; > + } > > + if (effect->params.count) > + { You can just get rid of the if entirely at this point. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19494

1 0

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/preshader.c: > struct d3dx_parameters_store *parameters) > { > unsigned int *p; > - unsigned int i, j, const_count; > + unsigned int i, j, const_count, magic; > double *dconst; > HRESULT hr; > unsigned int saved_word; > unsigned int section_size; > > + magic = *ptr; > + > TRACE("Preshader version %#x.\n", *ptr & 0xffff); It seems nice to also update the TRACE() to output the full 32-bit value. Additional nitpick: you can probably drop the "for 2 registers" part of the patch subject. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19493

1 0

[PATCH v3 0/1] MR1766: d3dx9_36/tests: Get rid of GCC12 warning.
by eric pouech (＠epo) 12 Dec '22

12 Dec '22

Follow GCC recommendations for getting rid of it. MingW/GCC 12 complains with: /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c: In function 'test_effect_parameter_value': /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: warning: expression does not compute the number of elements in this array; element type is 'DWORD' {aka 'long unsigned int'}, not 'D3DXMATRIX' {aka 'struct _D3DMATRIX'} [-Wsizeof-array-div] 1838 | const D3DXMATRIX *matrix_pointer_array[sizeof(input_value)/sizeof(D3DXMATRIX)]; | ^ /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: note: add parentheses around the second 'sizeof' to silence this warning /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1835:19: note: array 'input_value' declared here 1835 | DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; | ^~~~~~~~~~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v3: d3dx9/tests: Avoid a GCC warning (-Wsizeof-array-div). https://gitlab.winehq.org/wine/wine/-/merge_requests/1766

3 4

[PATCH 0/3] MR1794: Improvements to ntdll.Rtl*ByteSwap().
by eric pouech (＠epo) 12 Dec '22

12 Dec '22

- fixes effective calling convention used in test (causing some crashes #53536) - properly set entries in .spec files - only export these functions on 32bit - always inline them on 64bit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1794

2 3

[PATCH 0/1] MR1782: mshtml: Handle memory allocation failure in set_statustext.
by Alex Henrie (＠alexhenrie) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1782

3 2

[PATCH 0/1] MR1791: vbscript: Fix spelling in a FIXME message.
by Robert Wilhelm (＠sloper42) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1791

3 2

[PATCH v2 0/1] MR1766: d3dx9_36/tests: Get rid of GCC12 warning.
by eric pouech (＠epo) 12 Dec '22

12 Dec '22

Follow GCC recommendations for getting rid of it. MingW/GCC 12 complains with: /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c: In function 'test_effect_parameter_value': /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: warning: expression does not compute the number of elements in this array; element type is 'DWORD' {aka 'long unsigned int'}, not 'D3DXMATRIX' {aka 'struct _D3DMATRIX'} [-Wsizeof-array-div] 1838 | const D3DXMATRIX *matrix_pointer_array[sizeof(input_value)/sizeof(D3DXMATRIX)]; | ^ /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: note: add parentheses around the second 'sizeof' to silence this warning /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1835:19: note: array 'input_value' declared here 1835 | DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; | ^~~~~~~~~~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: d3dx9: Get rid of GCC warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/1766

3 3

[PATCH v3 0/2] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v3: wldap32: Free resource in error case (Coverity) urlmon: Pass correct parameter to realloc (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 3

[PATCH 0/1] MR1792: user32/tests: Ignore undocumented Win11 message
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54000 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1792

2 1

[PATCH 0/3] MR1763: winevulkan: Allow unix side thunks to tail call for performance critical functions.
by Rémi Bernon (＠rbernon) 12 Dec '22

12 Dec '22

I believe this performs similarly, if not better, than how direct calls previously performed. It is possible to make things even better with tail calls on the PE side, but it is going to be a little bit harder, and I'll make another MR later. FWIW except for vkoverhead benchmark, I still yet to see a real case scenario where it makes a difference, though I think this is straightforward enough. CC @mbriar -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1763

3 15

2025

2024

2023

2022

wine-gitlab