- wine-gitlab - winehq.org

[PATCH v3 0/5] MR2177: win32u: Get monitor name from EDID when possible
by Paul Gofman (＠gofman) 17 Feb '23

17 Feb '23

There are two common ways I observe how games get monitor name to display: 1. Registry key under Enum/Display (also present in EnumDisplayDevicesA result for monitors). On Windows this key is derived from edid as 'Manufacturer ID' (3 letters) combined with "Manufacturer product code" (4 hex digits). We currently have 'Default_Display' there for all the displays; 2. DisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME). Windows sets friendlyNameFromEdid flag and returns a name from 'EDID Display Descriptor' with code 0xfc ("Display name"). As far as I could see by searching through the Windows registry this name doesn't seem to be explicitly present anywhere in registry (besides binary raw edid of course). The first patch removes name from the gdi driver's display structure. Now none of the drivers set anything genuine there. x11 and winemac always end up with "Generic Non-Pnp Monitor" string, wineandroid sets NULL there and "Generic Non-Pnp Monitor" is set in win32u in this case. That "Generic Non-Pnp Monitor" goes to "DeviceDesc" registry value. While our value doesn't match Windows string exactly, Windows also doesn't have any meaningful name under DeviceDesc (and contains "Generic Non-Pnp Monitor" as a part of it). So this patch is essentially a no-op currently. Going forward my idea is that we just want to have edid from drivers. If the raw one is not available we can generate fallback one ourselves based on the info about the monitor we might have from elsewhere in the drivers. My motivation is: - EDID is sometimes queried by apps directly, and it is better to provide a true one or a synthetic one with as much of accurate info as possible / reasonable; - There is more info in EDID, e. g., colorimetry for HDR support in d3d. As far as I can tell, there is no documented way to query HDR info on Windows besides dxgi interfaces (which in case on Wine are based on gdi drivers for such things and can hardly become a genine source of such info in Wine) and WinRT interface (for which I don't know where it takes the info on Windows but we probably don't want to make it a lower level source of such info in Wine). The alternative would be, instead of basing higher level win32u on EDID, parse EDID in drivers instead and add all the necessary info into gdi_monitor structure (instead of removing display name from there), but so far it seems less straightforward to me. -- v3: win32u: Get friendly monitor name from EDID in NtUserDisplayConfigGetDeviceInfo(). win32u: Return edidManufactureId and edidProductCodeId from NtUserDisplayConfigGetDeviceInfo(). win32u: Store EDID info in monitors cache. win32u: Use monitor ID from EDID when available. win32u: Remove monitor name from gdi driver monitor info. https://gitlab.winehq.org/wine/wine/-/merge_requests/2177

3 8

[PATCH v4 0/2] MR2183: winecfg: Add an option to enable WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 17 Feb '23

17 Feb '23

This is what it looks like: **v1** ![Screenshot_20230213_212244](/uploads/14156031c91d4da29fc49ed9831b599a/Screenshot_20230213_212244.png) **v2** ![winecfg](/uploads/f610908b8ed2fbece6ef09ee5bd4d13e/winecfg.png) -- v4: winecfg: Add an option to enable WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

3 5

[PATCH v16 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 17 Feb '23

17 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v16: ddraw: Also Buffer D3DPT_POINTLIST ddraw: Add a local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

2 2

[PATCH 0/1] MR2197: rpcrt4: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2197

4 10

[PATCH 0/1] MR2202: msxml3: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2202

3 4

[PATCH v2 0/1] MR2203: msado15: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- v2: msado15: Use the _recalloc function instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2203

3 4

[PATCH 0/1] MR2201: oledb32: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2201

2 3

[PATCH v2 0/1] MR2199: wininet: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- v2: wininet: Use the _recalloc function instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2199

2 3

[PATCH 0/1] MR2198: hhctrl: Use the _recalloc function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 17 Feb '23

17 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2198

2 3

[PATCH 0/1] MR2223: msdasql: Use SQLColAttributesW to fetch statement attributes.
by Alistair Leslie-Hughes (＠alesliehughes) 17 Feb '23

17 Feb '23

We need to use the ODBC v1 function SQLColAttributesW, to ensure that we use the lowest verion available. This ODBC function internally will call SQLColAttribute or SQLColAttributesW depending on what the driver supports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2223

2 1

2025

2024

2023

2022

wine-gitlab