- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Matteo Bruni (＠Mystral) 29 Nov '22

29 Nov '22

Looks good otherwise :thumbsup: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556#note_17941

1 0

Re: [PATCH v2 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Matteo Bruni (＠Mystral) 29 Nov '22

29 Nov '22

Matteo Bruni (@Mystral) commented about dlls/d3dcompiler_43/compiler.c: > + { > + const char *ptr = messages; > + const char *line; > + > + ERR("Shader log:\n"); > + while ((line = get_line(&ptr))) > + { > + ERR(" %.*s", (int)(ptr - line), line); > + } > + ERR("\n"); > + } > + > + vkd3d_shader_free_messages(messages); > + } > + > + if (ret) return hresult_from_vkd3d_result(ret); Tiny nitpick: can you move the return to its own line? ```suggestion:-0+0 if (ret) return hresult_from_vkd3d_result(ret); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556#note_17940

1 0

Re: [PATCH v2 0/3] MR1555: wshom.ocx: Add WShNetwork. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1555

1 0

Re: [PATCH v3 0/3] MR1575: include: Add __WINE_(DEALLOC|MALLOC) attributes to wine_get_(dos|unix)_file_name. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1575

1 0

Re: [PATCH v2 0/1] MR1581: include: Annotate StrDup[AW] with __WINE_MALLOC and __WINE_DEALLOC. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1581

1 0

Re: [PATCH v3 0/2] MR1574: include: Add shobjidl_core.idl. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1574

1 0

Re: [PATCH v10 0/1] MR1522: mfmediaengine: Volume change. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

1 0

Re: [PATCH v12 0/3] MR1539: gdiplus: add support for Custom Line Indent. - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

1 0

Re: [PATCH v4 0/1] MR1551: SDL: Always make unique serial numbers - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1551

1 0

Re: [PATCH v3 0/5] MR1597: localspl: More work toward moving code from winspool.drv - approved
by Alexandre Julliard (＠julliard) 29 Nov '22

29 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1597

1 0

2025

2024

2023

2022

wine-gitlab