- wine-gitlab - winehq.org

[PATCH v3 0/6] MR1192: win32u: Improve handling of ppem == 0
by Tarcísio Ladeia de Oliveira (＠wyrquill) 03 Nov '22

03 Nov '22

Some fonts can end up with too low height for some sizes, resulting in ppem == 0, which can lead to some metrics becoming 0 too, especially tmHeight and tmAveCharWidth. This behavior is also observed on Windows, but on Linux it could lead to division by zero. This was noticed with the font `Emmentaler-Brace`, which comes with TexLive and GNU LilyPond, in the comctl32 status test. This patch set also tries to make the Wine behavior closer to the Windows one by enabling tmAveCharWidth to be 0 and preventing it and tmHeight from causing divisions by zero. This is very much an edge case, and I don't know if it has caused problems in actual programs, so I don't know if it would be worth it to make the behavior match exactly. But this way at least the tests should pass if some incomplete/misconfigured fonts are installed. I mainly limited myself to win32u. I'm not sure if these changes could affect behavior in other parts of the codebase, but the tests seems unchanged. -- v3: win32u: Allow tmAveCharWidth to be 0. win32u: Prevent division by 0 in get_transform_matrices(). win32u: check if tmAveCharWidth is 0 before division. win32u: Do not use SCALE_NTM if TM.tmHeight == 0. win32u: Warn when ppem == 0. win32u: Prevent division by zero in scale_font_metrics(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1192

3 7

Re: [PATCH v2 0/1] MR1214: include: Include minidumpapiset.h in imagehlp.h. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1214

1 0

Re: [PATCH v2 0/2] MR1217: winecfg: Use SM_CYSIZE to set and get caption height. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1217

1 0

Re: [PATCH v2 0/1] MR1219: ntdll: Fix building on Mojave / Xcode 11.3.1. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1219

1 0

Re: [PATCH v2 0/1] MR1226: winebus.sys: Ignore SDL events for devices which aren't started. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1226

1 0

Re: [PATCH v2 0/2] MR1227: winmm: Use a separate last_check for joyGetDevCapsW and joyGetPosEx. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1227

1 0

Re: [PATCH v2 0/1] MR1222: winex11.drv: Initialize escape.drawable in X11DRV_GetDC(). - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1222

1 0

Re: [PATCH v6 0/8] MR1223: msvcp90: add stream func implementation. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1223

1 0

Re: [PATCH v2 0/1] MR1208: winevulkan: Do not pass win32 allocation callbacks directly to the Unix side. - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1208

1 0

Re: [PATCH v2 0/1] MR1224: win32u: Skip detached monitors in is_window_rect_full_screen(). - approved
by Alexandre Julliard (＠julliard) 02 Nov '22

02 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1224

1 0

2025

2024

2023

2022

wine-gitlab