On Tue Mar 18 15:03:51 2025 +0000, Rémi Bernon wrote:
> I haven't found neither the PROCESS_PRIOCLASS nor the
> PROCESS_PRIORITY_CLASS constants in the SDK headers, where are you
> seeing them?
I was originally looking into that since the reported process base priority was not matching what windows reported and they were set to these values, so I thought they were wrong (which turned out to be not true for a different reason...).
In any case, [System Informer](https://systeminformer.sourceforge.io), which is luckily open-source and MIT licensed, displays them like so:
```
static CONST PH_KEY_VALUE_PAIR ProcessPriorityClassTypePairs[] =
{
SIP(SREF(L"Unknown"), PROCESS_PRIORITY_CLASS_UNKNOWN),
SIP(SREF(L"Idle"), PROCESS_PRIORITY_CLASS_IDLE),
SIP(SREF(L"Normal"), PROCESS_PRIORITY_CLASS_NORMAL),
SIP(SREF(L"High"), PROCESS_PRIORITY_CLASS_HIGH),
SIP(SREF(L"Real time"), PROCESS_PRIORITY_CLASS_REALTIME),
SIP(SREF(L"Below normal"), PROCESS_PRIORITY_CLASS_BELOW_NORMAL),
SIP(SREF(L"Above normal"), PROCESS_PRIORITY_CLASS_ABOVE_NORMAL),
};
```
A quick GitHub code search shows that these are used like so in a wide range of projects, whereas the current Wine naming of `PROCESS_PROCLASS_*` is basically only used by Wine.
This also adds the unknown case and starts from `0`, which are both nice-to-haves, and leads me to believe that this is also the original private API naming scheme. If this is still not worth it to do, I can also just drop the commit as well.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7516#note_98393
Main target of this serie is to support properly the
SYMOPT_LOAD_LINES option flag to dbghelp (turning it
off can save some memory).
Adding support for 128bit integers in PDB base types,
and silencing some more types.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7612
For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects.
--
v3: win32u: Use the session shared object to implement is_window.
win32u: Use the session shared object for user handle entries.
server: Move the user object handle table to the shared memory.
server: Use NTUSER_OBJ constants for user object types.
server: Create a shared memory object for the global session.
https://gitlab.winehq.org/wine/wine/-/merge_requests/7610
For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects.
--
v2: win32u: Use the session shared object to implement is_window.
win32u: Use the session shared object for user handle entries.
server: Move the user object handle table to the shared memory.
server: Use NTUSER_OBJ constants for user object types.
server: Create a shared memory object for the global session.
https://gitlab.winehq.org/wine/wine/-/merge_requests/7610
On Wed Mar 19 05:07:09 2025 +0000, Mohamad Al-Jaf wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/7597/diffs?diff_id=165075&start_sha=0c9df529abfdeb01208ee618b4cb766a0961ba69#d430fdc14e90f656acc7b2f3eb52d29c37bb640f_331_308)
That's a better method, thanks.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7597#note_98370
On Wed Mar 19 05:07:15 2025 +0000, Rémi Bernon wrote:
> Is it really useful to test such corner case here?
I'm not sure what you mean by corner case, the test fails on i386 because 0xdeadbeef is too big of an allocation. In any case, letting malloc handle it makes the check unnecessary.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7597#note_98369