- wine-gitlab - winehq.org

[PATCH v2 0/1] MR2001: Draft: riched20: Obtain the composition start index after deleting selection.
by Jinoh Kang (＠iamahuman) 24 Jan '23

24 Jan '23

Today, the Rich Edit control handles the WM_IME_STARTCOMPOSITION message by the computing the composition start position (imeStartIndex) _before_ calling ME_DeleteSelection(), which shifts the character positions after the range of deletion. If the selection were not empty, imeStartIndex immediately becomes stale, since it does not take into account the number of deleted characters before it. Fix this by computing imeStartIndex after the ME_DeleteSelection() call. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54318 cc/ @aricstewart (has no Developer access to wine/wine; cannot be assigned as a reviewer yet) -- v2: riched20: Obtain the composition start index after deleting selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2001

3 4

Re: [PATCH v2 0/1] MR2004: loader: Document the WINE_D3D_CONFIG environment variable. - approved
by Alexandre Julliard (＠julliard) 24 Jan '23

24 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2004

1 0

[PATCH 0/1] MR2007: services: Use a separate allocation for NotifyParamsArray[0].params.
by Rémi Bernon (＠rbernon) 24 Jan '23

24 Jan '23

The pointer might be freed by RPC NdrPointerFree, which will try to use a dedicated free call for the array elements, and fail. Found by running advapi32:service test with warn+heap. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2007

2 1

[PATCH 0/1] MR2006: sechost: Use heap_strdup_multi_AtoW for dependencies in CreateServiceA.
by Rémi Bernon (＠rbernon) 24 Jan '23

24 Jan '23

Found by running advapi32:service test with warn+heap. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2006

2 1

[PATCH 0/1] MR68: vkd3d-shader/hlsl: Support frac() intrinsic.
by Nikolay Sivov (＠nsivov) 24 Jan '23

24 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34242 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/68

3 4

[PATCH 0/1] MR2004: loader: Document the WINE_D3D_CONFIG environment variable.
by Floris Renaud (＠jkfloris) 24 Jan '23

24 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2004

2 1

[PATCH 0/1] MR67: vkd3d: Store a struct d3d12_descriptor_heap pointer in each CBV/SRV/UAV descriptor.
by Conor McCarthy (＠cmccarthy) 24 Jan '23

24 Jan '23

The PE build of vkd3d uses Windows critical sections for synchronisation, and these slow down on the very high lock/unlock rate during multithreaded descriptor copying in Shadow of the Tomb Raider. This patch speeds up the demo by about 8%. By comparison, using SRW locks in the allocators and locking them for read only where applicable is about 4% faster. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/67

3 2

[PATCH 0/1] MR2001: Draft: riched20: Obtain the composition start index after deleting selection.
by Jinoh Kang (＠iamahuman) 24 Jan '23

24 Jan '23

Today, the Rich Edit control handles the WM_IME_STARTCOMPOSITION message by the computing the composition start position (imeStartIndex) _before_ calling ME_DeleteSelection(), which shifts the character positions after the range of deletion. If the selection were not empty, imeStartIndex immediately becomes stale, since it does not take into account the number of deleted characters before it. Fix this by computing imeStartIndex after the ME_DeleteSelection() call. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54318 cc/ @aricstewart (has no Developer access to wine/wine; cannot be assigned as a reviewer yet) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2001

3 2

[PATCH 0/1] MR2003: win32u: Silence spurious FIXME in NtUserScrollWindowEx.
by Jacek Caban (＠jacek) 24 Jan '23

24 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54357 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2003

3 2

[PATCH v5 0/4] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 23 Jan '23

23 Jan '23

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v5: shlwapi: fixup leading and trailing typos in UrlFixupW shlwapi: check for colon in UrlFixupW kernelbase: Restructure UrlFixupW() shlwapi/tests: Add tests for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

3 5

2025

2024

2023

2022

wine-gitlab