@zfigura @iamahuman This is my first wine patch, I am not familiar with wine review process, and I am not sure who should review this (bot didn't assign anybody), but I would appreciate a review.
Code should be obvious, but question for the last commit: should I open with `O_CLOEXEC` ? I do not think so, but would be good to confirm.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8713
On Fri Sep 16 15:29:32 2022 +0000, Gabriel Ivăncescu wrote:
> It worked properly earlier likely because there were no conflicts. Use
> git locally as normal instead of the web interface to do it.
yes I know that, but when I clicked the rebase button the pipeline started failing for no reason, now I have to rebase locally which I understand
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8706
--
v2: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block.
ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block.
ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block.
ntdll: The async handle passed to set_async_direct_result() cannot be NULL.
ws2_32/tests: Add more tests for iosb contents while a recv is pending.
https://gitlab.winehq.org/wine/wine/-/merge_requests/871
Alternatively, since this is early in startup and we don't expect this malloc()
to fail, we could simply remove the check from get_initial_environment() itself.
--
v2: ntdll: Do not check for malloc() failure in get_initial_environment.
https://gitlab.winehq.org/wine/wine/-/merge_requests/867
--
v2: winegstreamer: Check for already opened stream in wm_reader_open*.
winegstreamer: Use a dedicated CS to serialize async reader commands.
winegstreamer: Introduce a new async_reader_deliver_sample helper.
winegstreamer: Wake thread when async reader user clock is modified.
https://gitlab.winehq.org/wine/wine/-/merge_requests/843