- wine-gitlab - winehq.org

[PATCH v4 0/4] MR1554: Draft: win32u: Update focused item when removing menu item
by Vladislav Timonin (＠vt) 30 Nov '22

30 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split button dropdown - click on any item - clear dropdown items - open dropdown again Menu borked and won't open again. Source for the testing app for reproduction. [test.c](/uploads/2f703f63891b33e1a0eb0fcd27c912b7/test.c) I guess, the alternative is to reset focused item when menu is closed, but not sure where's the best place to do that, haven't dug deep enough. -- v4: win32u: Reset focused item if it was removed when removing a menu item win32u: Allow select_item to work with off-screen menus win32u: Add deselect to HiliteMenuItem win32u: Return FALSE in HiliteMenuItem when window handle is NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/1554

3 5

[PATCH 0/3] MR1606: d3dx9/preshader: Move register table debug names to the rest of table info.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1606

3 6

[PATCH 0/3] MR1613: kernelbase: More LocalReAlloc tests and fixes with LFH blocks.
by Rémi Bernon (＠rbernon) 30 Nov '22

30 Nov '22

The LFH being automatically enabled after several allocations of the same sizes are done, its reallocation strategy differs from non-LFH blocks and was messing with the tests. I previously removed the HEAP_REALLOC_IN_PLACE_ONLY flag from LocalReAlloc, based on the test results, but the outcome is different when a non-LFH block size is used. This adds more tests and restores the flag to fix the regression. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1613

2 3

[PATCH v12 0/2] MR1268: wininet: Partially implement InternetSetFilePointer
by Jason Kuo (＠j20001970) 30 Nov '22

30 Nov '22

-- v12: wininet: Partially implement InternetSetFilePointer wininet/tests: Add InternetSetFilePointer tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1268

3 7

Re: [PATCH v3 0/4] MR1589: Start of enabling long integral types in wined3d.
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

hmm doesn't look good... closing to startup fresh (sorry Jan) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589#note_18051

1 0

Re: [PATCH v3 0/4] MR1589: Start of enabling long integral types in wined3d. - closed
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

This merge request was closed by eric pouech. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589

1 0

[PATCH 0/4] MR1589: Start of enabling long integral types in wined3d.
by eric pouech (＠epo) 30 Nov '22

30 Nov '22

This enabling will be done on a file basis (instead of directory) to ease review. This serie contains "simple" file migration (mostly refcount and status/GetLastError()) changes. I likely post afterwards each file change in a single MR to ease up review (and potentially changes) without blocking the others. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1589

5 14

[PATCH v7 0/8] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 30 Nov '22

30 Nov '22

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v7: kernelbase: Factor creating a subkey out of create_key(). kernelbase: Use open_subkey() in create_key(). kernelbase: Always try to open the Wow6432Node in create_key() kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 9

[PATCH 0/5] MR1560: d3d10/effect: Preshader instructions support improvements.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1560

4 8

[PATCH v3 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53964 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: vbscript: Make redim fail on fixed-size arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/1604

4 4

2025

2024

2023

2022

wine-gitlab