On Fri Nov 14 14:38:51 2025 +0000, Giovanni Mascellani wrote:
> [I triggered a CI pipeline with
> tests](https://gitlab.winehq.org/giomasce/wine/-/pipelines/52738) and
> AFAICT winscard tests were run without failures. Does that make sense
> for you? There are some 64-bit failures in dinput, is there any chance
> they're related?
Is that a pure 32-bit build? That would explain it. The tests fail here on old wow64 on my machine. I don't think the dinput failures are related.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9466#note_122067
The last commit in particular fixes the crashes in Windows.
--
v2: mf/tests: Create all MF test objects on the heap.
mf/tests: Set test media stream sample duration by default and update current time on seek.
https://gitlab.winehq.org/wine/wine/-/merge_requests/9294
On Fri Nov 14 13:53:16 2025 +0000, Giovanni Mascellani wrote:
> The image changes are not yet visible in the CI pipeline triggered by
> this MR. The image is recreated only when the changes are pushed to
> master. And in my test CI pipeline (with the updated image) I indeed
> forgot to reenable tests. Let me try again, if that's indeed a problem
> I'll discard this patch: the one I'm really interested into is the other
> one, that was just because I had noticed something else was missing and
> I thought it was not intentional.
[I triggered a CI pipeline with tests](https://gitlab.winehq.org/giomasce/wine/-/pipelines/52738) and AFAICT winscard tests were run without failures. Does that make sense for you? There are some 64-bit failures in dinput, is there any chance they're related?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9466#note_122064
On Fri Nov 14 13:40:48 2025 +0000, Hans Leidekker wrote:
> We left this one out because we don't support the old wow64
> configuration, which makes the tests fail. Looks like the 32-bit
> winscard tests were skipped for this MR, not sure why.
The image changes are not yet visible in the CI pipeline triggered by this MR. The image is recreated only when the changes are pushed to master. And in my test CI pipeline (with the updated image) I indeed forgot to reenable tests. Let me try again, if that's indeed a problem I'll discard this patch: the one I'm really interested into is the other one, that was just because I had noticed something else was missing and I thought it was not intentional.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9466#note_122049
Hans Leidekker (@hans) commented about tools/gitlab/image.docker:
> libkrb5-dev:i386 \
> liborc-0.4-dev:i386 \
> libpcap-dev:i386 \
> + libpcsclite-dev:i386 \
We left this one out because we don't support the old wow64 configuration, which makes the tests fail. Looks like the 32-bit winscard tests were skipped for this MR, not sure why.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9466#note_122048