Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray.
--
v14: shell32: add support for balloon icon copying
https://gitlab.winehq.org/wine/wine/-/merge_requests/2875
--
v4: jscript: Return JS_E_OBJECT_NOT_COLLECTION when object has no DISPID_NEWENUM.
mshtml: Return MSHTML_E_INVALID_PROPERTY when trying to construct a legacy
mshtml/tests: Add more host object related tests for IE9+ modes.
jscript: Use deferred fill-in if available to fill the exception info.
jscript: Use proper dispatch flags to retrieve the enumerator.
mshtml: Implement retrieving the builtin method props for the legacy
mshtml: Move formatting of the builtin func disp string to a helper.
mshtml: Use designated initializers for function_dispex.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6515
--
v3: jscript: Return JS_E_OBJECT_NOT_COLLECTION when object has no DISPID_NEWENUM.
mshtml: Return MSHTML_E_INVALID_PROPERTY when trying to construct a legacy
mshtml/tests: Add more host object related tests for IE9+ modes.
jscript: Use deferred fill-in if available to fill the exception info.
jscript: Use proper dispatch flags to retrieve the enumerator.
mshtml: Implement retrieving the builtin method props for the legacy
mshtml: Move formatting of the builtin func disp string to a helper.
mshtml: Use designated initializers for function_dispex.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6515
--
v2: jscript: Return JS_E_OBJECT_NOT_COLLECTION when object has no DISPID_NEWENUM.
mshtml: Return MSHTML_E_INVALID_PROPERTY when trying to construct a legacy
mshtml/tests: Add more host object related tests for IE9+ modes.
jscript: Use deferred fill-in if available to fill the exception info.
jscript: Use proper dispatch flags to retrieve the enumerator.
mshtml: Implement retrieving the builtin method props for the legacy
mshtml: Move formatting of the builtin func disp string to a helper.
mshtml: Use designated initializers for function_dispex.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6515
On Wed Sep 18 15:02:39 2024 +0000, Philipp Knechtges wrote:
> Is this a showstopper? Maybe to elaborate: I guess a CDT for the
> "standard" faces would be the way to go, and could reuse much of the
> code for PathGeometries. However, the Bezier and Arc patch handling
> probably would be still special, and as said a lot of work. Hence,
> copying is in my opinion a good first approximation.
I think it is, because it will produce incorrect rendering. First priority is to have it working correctly, then we can deal with possible duplication.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82549
On Fri Sep 13 19:59:21 2024 +0000, Philipp Knechtges wrote:
> In my opinion the correct way would probably be populating a joint CDT
> from all the geometries and then erasing triangles depending on the
> fill_mode. However, this is a bigger undertaking and for the
> [bug](https://bugs.winehq.org/show_bug.cgi?id=51139) at hand it suffices
> to just concatenate all lists, since it seems the application uses the
> geometry groups for assembling glyphs to words and render them all at
> once. Due to the latter, there is no intersection between the different
> geometric entities.
Is this a showstopper? Maybe to elaborate: I guess a CDT for the "standard" faces would be the way to go, and could reuse much of the code for PathGeometries. However, the Bezier and Arc patch handling probably would be still special, and as said a lot of work. Hence, copying is in my opinion a good first approximation.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6492#note_82547