On Tue Sep 3 17:43:38 2024 +0000, Ostap Brehin wrote:
> Thank you! will update.
> Regarding not devoting an entire line for each parameter - not sure if
> that's possible due to enforced `max_line_length = 100` in
> [.editorconfig](https://gitlab.winehq.org/wine/wine/-/blob/master/.editorconfig),
> as then the new line size would be about 300 characters if that's the case.
Or you can put 2-4 params per line.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80919
On Tue Sep 3 17:29:39 2024 +0000, Alex Henrie wrote:
> If we're going to do this, can we please use `void *` instead of
> `LPVOID`, name each parameter in snake_case, and not devote an entire
> line to each parameter?
Thank you! will update.
Regarding not devoting an entire line for each parameter - not sure if that's possible due to enforced `max_line_length = 100` in [.editorconfig](https://gitlab.winehq.org/wine/wine/-/blob/master/.editorconfig), as then the new line size would be about 300 characters if that's the case.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80917
Alex Henrie (@alexhenrie) commented about include/winbase.h:
> * This one seems to be a Win32 only definition. It also is defined with
> * WINAPI instead of CALLBACK in the windows headers.
> */
> -typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE_INTEGER,
> - LARGE_INTEGER, DWORD, DWORD, HANDLE,
> - HANDLE, LPVOID);
> +typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(
> + LARGE_INTEGER TotalFileSize,
> + LARGE_INTEGER TotalBytesTransferred,
> + LARGE_INTEGER StreamSize,
> + LARGE_INTEGER StreamBytesTransferred,
> + DWORD dwStreamNumber,
> + DWORD dwCallbackReason,
> + HANDLE hSourceFile,
> + HANDLE hDestinationFile,
> + LPVOID lpData
If we're going to do this, can we please use `void *` instead of `LPVOID`, name each parameter in snake_case, and not devote an entire line to each parameter?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80916