- wine-gitlab - winehq.org

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by eric pouech (＠epo) 16 Feb '25

16 Feb '25

eric pouech (@epo) commented about programs/cmd/directory.c: > if ((file_total + dir_total == 0) && (level == 0)) { > SetLastError (ERROR_FILE_NOT_FOUND); > WCMD_print_error (); > errorlevel = ERROR_INVALID_FUNCTION; this shouldn't set errorlevel but return_code and likely using ERROR_FILE_NOT_FOUND to mark that listing was empty -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94818

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by eric pouech (＠epo) 16 Feb '25

16 Feb '25

eric pouech (@epo) commented about programs/cmd/directory.c: > WCHAR fname[MAX_PATH]; > WCHAR ext[MAX_PATH]; > unsigned num_empty = 0, num_with_data = 0; > + RETURN_CODE return_code = NO_ERROR; > > errorlevel = NO_ERROR; this should not be necessary (in fact starting from here up the exit of the function, you should only deal with return_code... errorlevel should be set upon exiting) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94817

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by eric pouech (＠epo) 16 Feb '25

16 Feb '25

eric pouech (@epo) commented about programs/cmd/directory.c: > /* Clear any errors from previous invocations, and process it */ > errorlevel = NO_ERROR; this should be return_code -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94815

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Robbert van der Helm (＠robbert-vdh) 16 Feb '25

16 Feb '25

On Sun Feb 16 07:21:41 2025 +0000, Brian Wright wrote: > Bah. There were too many changes to X11DRV_ConfigureNotify for printf > debugging, and I wouldn't know what to change that also keeps other > programs from breaking. > I can provide detailed logs for 9.21 (or any interim versions), but > that's about all I can do For the record, all of these `ConfigureNotify` events were a hack to let Wine know where on screen the window is, which happened to work way better than it should and it resulted in more more reliable behavior than Wine's built in XEmbed support at the time. Ideally, yabridge would just use XEmbed instead and Wine would keep track of the screen coordinates. If you enable yabridge's XEmbed support then it stops sending these `ConfigureNotify` messages and it will use XEmbed instead. But I also have not yet been able to get that to work as expected with the latest Wine version. I spent a couple hours debugging Wine's X11 driver last Friday but I haven't figured out what goes wrong or what's missing yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_94810

1 0

[PATCH v25 0/32] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 16 Feb '25

16 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v25: dlls/oleaut32: Replace infinite loops with for loops dlls/oleaut32: Use consistent SegDir field names This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

1 0

Re: [PATCH v10 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

On Sun Feb 16 08:08:14 2025 +0000, Joe Souza wrote: > Looking through the existing code, especially WCMD_directory, there > seems to be no distinction between errorlevel and the RETURN_CODE that > the function returns. In most cases I see the code set errorlevel to > some value and then the function returns errorlevel. OK, I *think* the latest changes are pretty close to what you asked for. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7322#note_94807

1 0

[PATCH v9 0/1] MR7322: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C.
by Joe Souza (＠JoeS209) 16 Feb '25

16 Feb '25

Allow the user to press Ctrl-C to abort lengthy DIR (or DIR /p, etc.) operations. -- v9: programs/cmd: Implement ability to abort lengthy directory operations via Ctrl-C. https://gitlab.winehq.org/wine/wine/-/merge_requests/7322

2 1

Re: [PATCH v2 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Aida Jonikienė (＠DodoGTA) 16 Feb '25

16 Feb '25

Maybe there's way to compile libxml2 as ELF? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7339#note_94804

1 0

Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.
by Brian Wright (＠PennRobotics) 16 Feb '25

16 Feb '25

On Sun Feb 16 01:21:13 2025 +0000, Brian Wright wrote: > I updated the bug tracker again. > In REAPER, the window tree looks a bit like this: > ```text > host_window_reparent parent 402, window 200192 (604,402)-(1516,1110) > host_window_reparent parent 200192, window 200193 (0,0)-(912,708) > root_coords 1 > host_window_reparent parent 200193, window 1600130 (0,0)-(912,708) > root_coords 1 > host_window_reparent parent 1600130, window 16012db (0,0)-(644,659) > root_coords 1 > host_window_reparent parent 16012db, window 2200000 (0,0)-(805,460) > root_coords 1 > host_window_reparent parent 2200000, window 2000003 (0,0)-(1920,1200) > root_coords 0 > ``` > I think 402, 200192, and 200193 are from REAPER and the rest from yabridge. > One detail I noticed is that window 2000003 gets the initial click event > from yabridge and sends the correct value to > **cursor:map_event_coords**. I don't know the structure of > event->window, but there is something in > [**host_window_configure_child**](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winex11.drv/window.c#L229) > that messes with coordinate offsets. > Is is possible that **map_event_coords** should check the value of > `root_coords` (aka `event->send_event`) and provide `(pt->x, pt->y)` > when this is 0? > I'll keep picking at things and see if there's more to find. > ----- > Alternatively, a flag/argument solution would get DAW users back in action. Bah. There were too many changes to X11DRV_ConfigureNotify for printf debugging, and I wouldn't know what to change that also keeps other programs from breaking. I can provide detailed logs for 9.21 (or any interim versions), but that's about all I can do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_94802

1 0

[PATCH v10 0/4] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 15 Feb '25

15 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- v10: winewayland: Post IME update for preedit text. https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

3 5

2025

2024

2023

2022

wine-gitlab