On Mon Feb 10 20:30:31 2025 +0000, Jacek Caban wrote:
> Sorry for not noticing it later, but looking at oleaut32 code, I think
> that we should iterate `data` pointer from 0 index here. I fixed that,
> changed a bit the style to be more consistent with vbscipt and created
> !7304. I hope it's fine for you. Thanks!
Sure. Anything that pushes this through is ok by me.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_94181
Jacek Caban (@jacek) commented about dlls/vbscript/global.c:
> +
> + hres = SafeArrayAccessData(sa, (void**)&data);
> + if (FAILED(hres))
> + goto cleanup;
> +
> + str_array = (BSTR *)malloc((ubound - lbound + 1) * sizeof(BSTR));
> + if (!str_array) {
> + hres = E_OUTOFMEMORY;
> + goto cleanup_data;
> + }
> + free_str_array = (BSTR *)calloc((ubound - lbound + 1), sizeof(BSTR));
> + if (!free_str_array) {
> + hres = E_OUTOFMEMORY;
> + goto cleanup_data;
> + }
> + for (i = lbound; i <= ubound; i++) {
Sorry for not noticing it later, but looking at oleaut32 code, I think that we should iterate `data` pointer from 0 index here. I fixed that, changed a bit the style to be more consistent with vbscipt and created !7304. I hope it's fine for you. Thanks!
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_94179
Fixes long uptimes causing Parkan: Iron Strategy to hang shortly after
starting a mission and laggy arrows in GTA San Andreas lowrider
challenge. The games seem to not like low values either so add a 5
minute offset to the counter.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/7299
--
v2: windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformRotate90) for bitmaps with bpp >= 8.
windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformFlipHorizontal) for bitmaps with bpp >= 8.
windowscodecs/tests: Add some tests for IWICBitmapFlipRotator.
https://gitlab.winehq.org/wine/wine/-/merge_requests/7211
Startup and lock counts in native Windows are separate, and the lock count does not decrease when an async result is freed if the platform has been started.
--
v4: rtworkq: Introduce an async result object cache.
rtworkq: Introduce a platform startup count.
rtworkq/tests: Test work queue.
mfplat/tests: Test platform startup and lock counts.
mfplat/tests: Test mixing of MF platform functions with their Rtwq equivalents.
mfplat/tests: Introduce a helper to check the platform lock count.
https://gitlab.winehq.org/wine/wine/-/merge_requests/7174