- wine-gitlab - winehq.org

[PATCH 0/4] MR7143: dlls, tools: transferring strlen calls out of bounds loops
by Herman Semenov (＠GermanAizek) 14 Jan '25

14 Jan '25

This is more code refactoring than micro-optimization. Modern compilers may skip optimizations in some places, so we strictly make it clear to them that we need common variable to determine const result strlen() function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7143

5 8

Re: [PATCH v8 0/1] MR4174: shell32: Add Internet Explorer toolbar icons.
by Alex Henrie (＠alexhenrie) 14 Jan '25

14 Jan '25

On Tue Jan 14 07:51:31 2025 +0000, Jacek Caban wrote: > Sorry for the delay, I'm not sure what to think about it. If it's > dropped in modern Windows, it's not clear if we want it. I guess it > wouldn't hurt... > We usually add SVGs so that maintainer mode can generate binary blobs. > It seems that Tango theme repo contains SVGs, could we use them? Hi Jacek, thanks for the review. When I wrote this patch, I considered combining the Tango SVGs into a single SVG file that would be converted to a PNG when building in Wine maintainer mode, but it turned out to be more trouble than it was worth. It's trivial to combine PNG files with ImageMagick, whereas combining SVG files requires a lot of manual effort. Moreover, no one cares about modifying these icons or has made an argument for why different icons would be better than the Tango defaults. And if in the future someone decides to import the SVGs into Wine, the resulting PNG will still have to be regenerated and replaced in the Git repository; we have to have a PNG in Git regardless of how it is created. It seems to me that we either need to merge a patch like the one I am proposing, or we need to close [Bug 40236](https://bugs.winehq.org/show_bug.cgi?id=40236) as WONTFIX and remove the [patches in Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/s…. The most important thing is just to make a decision. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4174#note_91975

1 0

Re: [PATCH v2 0/1] MR7135: gdiplus/tests: Fix use-after-free of a graphics object (ASan). - approved
by Esme Povirk (＠madewokherd) 14 Jan '25

14 Jan '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7135

1 0

Re: [PATCH v2 0/1] MR7141: winex11: Always blit offscreen over any other onscreen clients. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7141

1 0

Re: [PATCH v2 0/1] MR7140: winex11: Adjust requested visible rect relative to the previous position. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7140

1 0

Re: [PATCH v3 0/1] MR7139: configure: Use per-architecture cross flags if they are provided. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7139

1 0

Re: [PATCH v2 0/2] MR7127: msi: Set features to absent if advertising is disallowed. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7127

1 0

Re: [PATCH v2 0/1] MR7136: winex11.drv: Fix display name in X11DRV_UpdateDisplayDevices(). - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7136

1 0

Re: [PATCH v2 0/1] MR7107: gdi32: Avoid crashing when tracing NULL xform. - approved
by Alexandre Julliard (＠julliard) 13 Jan '25

13 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7107

1 0

[PATCH 0/1] MR7141: winex11: Always blit offscreen over any other onscreen clients.
by Rémi Bernon (＠rbernon) 13 Jan '25

13 Jan '25

Since we're checking the child window clipping rules it is possible that a toplevel window also has an onscreen client window, for instance if the window wasn't created with WS_CLIPCHILDREN. The last window to present between the parent and its children should be visible. GDI blits always happen over the toplevel window, and we need to use IncludeInferiors to make sure it goes through any onscreen client window that is otherwise hiding the toplevel pixels. It should be safe to use that flag wrt other child windows, as we also set the clipping region to exclude the area that should be obscured by any sibling. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57661 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7141

2 1

2025

2024

2023

2022

wine-gitlab