- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR7104: winex11: Check window region instead of forcing offscreen on parent. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7104

1 0

Re: [PATCH v2 0/1] MR7103: po: Update Simplified Chinese translation. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7103

1 0

Re: [PATCH v2 0/1] MR7015: mmdevapi/test: Fix audio clock adjustment tests failing in testbot. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7015

1 0

Re: [PATCH v2 0/1] MR7067: gdi32: Explicitly check for negative text length in GetTextExtentExPointW(). - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7067

1 0

Re: [PATCH v2 0/1] MR7086: include: Fix method arguments annotations in dwrite.idl. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7086

1 0

Re: [PATCH v5 0/1] MR7009: ntdll: Emulate mrs xN, CurrentEL instructions. - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7009

1 0

Re: [PATCH v2 0/2] MR7100: Finnish translation - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7100

1 0

Re: [PATCH v2 0/1] MR7096: d3dx9_36/tests: Fix test data buffer underflow (ASan). - approved
by Alexandre Julliard (＠julliard) 06 Jan '25

06 Jan '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7096

1 0

Re: [PATCH v4 0/1] MR7052: vbscript: implement Join()
by Jacek Caban (＠jacek) 06 Jan '25

06 Jan '25

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + str = V_BSTR(&data[i]); > + > + if (i > lbound) { > + string_len = SysStringLen(string); > + tmp = SysAllocStringLen(string, string_len + delimiter_len); > + memcpy(tmp + string_len, delimiter, delimiter_len * sizeof(WCHAR)); > + SysFreeString(string); > + string = tmp; > + } > + > + string_len = SysStringLen(string); > + str_len = SysStringLen(str); > + tmp = SysAllocStringLen(string, string_len + str_len); > + memcpy(tmp + string_len, str, str_len * sizeof(WCHAR)); > + SysFreeString(string); > + string = tmp; That's potentially a lot of string reallocation. A cleaner and more efficient approach would be to first convert all necessary strings and store the results as pointers in an array and calculate the required length. Then, allocate the output buffer, and copy all the joined strings into it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_91500

1 0

Re: [PATCH v4 0/1] MR7052: vbscript: implement Join()
by Jacek Caban (＠jacek) 06 Jan '25

06 Jan '25

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + if(V_VT(args+1) != VT_BSTR) > + { > + hres = to_string(args+1, &delimiter); > + if(FAILED(hres)) { > + return hres; > + } > + } > + else > + delimiter = V_BSTR(args+1); > + } > + else > + delimiter = SysAllocString(L" "); > + > + if (SafeArrayGetDim(sa) != 1) > + return E_NOTIMPL; It's fine to skip this, but unless native returns E_NOTIMPL as well, please add a `FIXME` message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_91499

1 0

2025

2024

2023

2022

wine-gitlab