- wine-gitlab - winehq.org

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Brendan McGrath (＠redmcg) 05 Mar '25

05 Mar '25

On Wed Mar 5 01:20:21 2025 +0000, Brendan McGrath wrote: > I just tried to build this in a container running debian bullseye and > got the following error: > ``` > ../../dlls/winegstreamer/wg_transform.c:68:50: error: expected ')' > before string constant > 68 | GST_ELEMENT_REGISTER_DEFINE(winegstreamerstepper, > "winegstreamerstepper", GST_RANK_NONE, GST_TYPE_WG_STEPPER); > | ^~~~~~~~~~~~~~~~~~~~~~~ > | ) > ``` > I _think_ that's because bullseye is running gstreamer version 1.18, > whilst the documentation suggests `GST_ELEMENT_REGISTER_DEFINE` was > added version 1.20. > I think we'll need to address this as I _think_ Crossover is built > against bullseye. I was able to resolve this by copying the defines to our code (and declaring them if GStreamer version is < 1.20): [winegstreamer.patch](/uploads/caf23dfb5e167f828b2709b17eb519fb/winegstreamer.patch) I'm not sure that's the way we want to go; but I'll raise an MR with that (and I'll close it if there's a better option). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_96820

1 0

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Brendan McGrath (＠redmcg) 05 Mar '25

05 Mar '25

I just tried to build this in a container running debian bullseye and got the following error: ``` ../../dlls/winegstreamer/wg_transform.c:68:50: error: expected ')' before string constant 68 | GST_ELEMENT_REGISTER_DEFINE(winegstreamerstepper, "winegstreamerstepper", GST_RANK_NONE, GST_TYPE_WG_STEPPER); | ^~~~~~~~~~~~~~~~~~~~~~~ | ) ``` I _think_ that's because bullseye is running gstreamer version 1.18, whilst the documentation suggests `GST_ELEMENT_REGISTER_DEFINE` was added version 1.20. I think we'll need to address this as I _think_ Crossover is built against bullseye. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288#note_96816

1 0

Re: [PATCH v6 0/10] MR7407: windowscodecs: Implement query strings enumerator. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7407

1 0

Re: [PATCH v3 0/6] MR7436: d3dx9: More changes to D3DXSaveSurfaceToFileInMemory(). - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7436

1 0

Re: [PATCH v2 0/1] MR7488: include: Use wchar_t for platform types on PE targets. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7488

1 0

Re: [PATCH v3 0/4] MR7468: win32u: Move opengl code to a dedicated source. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7468

1 0

Re: [PATCH v2 0/5] MR7483: wineps: Cleanups for the new core font metrics generation code. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7483

1 0

Re: [PATCH v2 0/1] MR7487: propsys/tests: Fix check_PropVariantToBSTR2. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7487

1 0

Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

1 0

Re: [PATCH v2 0/1] MR7478: user32: Use the correct DPI in AdjustWindowRect(Ex) when DPI virtualization is active. - approved
by Alexandre Julliard (＠julliard) 04 Mar '25

04 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7478

1 0

2025

2024

2023

2022

wine-gitlab