- wine-gitlab - winehq.org

Re: [PATCH v14 0/0] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) 21 Aug '25

21 Aug '25

On Thu Aug 21 10:16:27 2025 +0000, Ivan Lyugaev wrote: > changed this line in version 7 of the diff I agree with you, the save_cfg_data section is divided into two functions, save_option(optno) and save_options(void) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113438

1 0

Re: [PATCH v14 0/0] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) 21 Aug '25

21 Aug '25

On Thu Aug 21 10:16:26 2025 +0000, Ivan Lyugaev wrote: > changed this line in version 7 of the diff Yes, I agree, my interface makes writing and reading the whole file, but in the context of a small number of operations, I think it's acceptable. I focused on making the configuration file readable for manual modification (previously, I provided the writing format). An option was to store the settings in a binary file and overwrite them based on the offset provided by optno. Would it be better to store all the settings in memory and save them to a file once the scan starts or the window is closed? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113429

1 0

Re: [PATCH v14 0/0] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) 21 Aug '25

21 Aug '25

On Thu Aug 21 10:16:26 2025 +0000, Ivan Lyugaev wrote: > changed this line in version 7 of the diff When a string parameter is set in the sane_option_set_value function, it becomes impossible to retrieve the number of parameters in the sane_option_get_value function. This is likely an internal feature of sane. This was added to correctly display the loaded parameters. Without this change, the tab had to be refreshed, which was inconvenient. In my opinion, it is safe to use this, as my gOptCount variable is updated every time the optcount is successfully received in the sane_option_get_value( 0, &optcount ) function, which is called in DoScannerUi and InitializeDialog -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113428

1 0

[PATCH 0/2] MR8805: vkd3d: Import upstream release 1.17.
by Alexandre Julliard (＠julliard) 21 Aug '25

21 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8805

2 2

Re: [PATCH v14 0/0] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) 21 Aug '25

21 Aug '25

On Thu Aug 21 10:16:26 2025 +0000, Ivan Lyugaev wrote: > changed this line in version 7 of the diff This solution is based on previously defined values such as ID_STATIC_BASE and etc. These values are also not used anywhere else, so it is not rational to create a new file for them -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113426

1 0

Re: [PATCH v14 0/0] MR8778: sane.ds: Adding a window for loading and saving the scanner configuration
by Ivan Lyugaev (＠valy) 21 Aug '25

21 Aug '25

On Thu Aug 21 10:16:25 2025 +0000, Ivan Lyugaev wrote: > changed this line in version 7 of the diff The format of the config entry looks like this: name=value I meant that the value of the scanner parameter is a whole word without spaces. But I will correct the solution to take into account spaces inside -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8778#note_113425

1 0

[PATCH v4 0/3] MR8614: wininet/internet: Fix parsing order of http times.
by Jacob Czekalla (＠JacobCzekalla) 21 Aug '25

21 Aug '25

Order of day or month and time or year needs to be considered. The year also needs to be adjusted correctly. -- v4: wininet/internet: Fix year parsing to include millennium. wininet/internet: Fix parsing order of http times. wininet/tests: Add more http time test strings. https://gitlab.winehq.org/wine/wine/-/merge_requests/8614

3 4

[PATCH v3 0/4] MR8781: jscript: Misc array and toString fixes.
by Gabriel Ivăncescu (＠insn) 21 Aug '25

21 Aug '25

-- v3: jscript: Fix error value when passing non-string 'this' to String's toString. jscript: Fallback to Object's toString for Arrays when 'this' isn't an jscript: Return proper error when passing wrong type to Function.apply. jscript: Allow objects that expose "length" prop for Function.apply under https://gitlab.winehq.org/wine/wine/-/merge_requests/8781

3 5

[PATCH v3 0/11] MR8782: iphlpapi: Implement ipv6 ping.
by Paul Gofman (＠gofman) 21 Aug '25

21 Aug '25

-- v3: iphlpapi/tests: Add tests for Icmp6SendEcho2(). iphlpapi: Implement Icmp6SendEcho2(). nsiproxy.sys: Don't try to check for original packet for ping socket. iphlpapi: Implement Icmp6CreateFile(). iphlpapi: Implement Icmp6ParseReplies(). iphlpapi: Only supply APC routine if no event in icmp_send_echo(). iphlpapi/tests: Refactor APC testing in testIcmpSendEcho(). iphlpapi: Factor out icmp_send_echo() function. nsiproxy.sys: Store socket type in struct icmp_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/8782

3 12

[PATCH v2 0/3] MR8804: server: Return NULL from get_first_valid_hook when no hook is found.
by Rémi Bernon (＠rbernon) 21 Aug '25

21 Aug '25

Fixes: 5b7b76432dffa453e75c6336d76fdb856ab8d0c7 -- v2: server: Use LIST_FOR_EACH_ENTRY in get_next_hook. server: Return NULL from get_next_hook when no hook is found. https://gitlab.winehq.org/wine/wine/-/merge_requests/8804

2 5

2025

2024

2023

2022

wine-gitlab