On Wed Aug 20 17:08:48 2025 +0000, Tres Finocchiaro wrote:
> I've added a second flag for `HIGHENTROPYVA`. This new flag is longer
> and breaks some styling. Any advice is greatly appreciated. I've
> placed the style foopahs inline.
That second flag doesn't seem necessary.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113306
Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c:
> { "dll", 0, LONG_OPT_DLL },
> { "def", 0, LONG_OPT_DEF },
> { "disable-dynamicbase", 0, LONG_OPT_DISABLE_DYNAMICBASE },
> + { "disable-high-entropy-va", 0, LONG_OPT_DISABLE_HIGH_ENTROPY_VA },
I would appreciate any advice from the winehq team here on styling. Mimicking the existing format for section will touch many more lines.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113298
Tres Finocchiaro (@tresf) commented about tools/winebuild/main.c:
> " -d, --delay-lib=LIB Import the specified library in delayed mode\n"
> " -D SYM Ignored for C flags compatibility\n"
> " --disable-dynamicbase Disable 'ASLR' address space layout randomization (default: ASLR on)\n"
> +" --disable-high-entropy-va Disable high-entropy 64-bit 'ASLR' (default: high-entropy on).\n"
I would appreciate any advice from the winehq team here on styling. Mimicking the format this section for 80 chars will touch many more lines.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8786#note_113297