- wine-gitlab - winehq.org

[PATCH v2 0/1] MR7035: server: Avoid crash when handle table is allocated but not yet filled.
by Bernhard Übelacker (＠bernhardu) 17 Dec '24

17 Dec '24

I was experimenting with a Wine tree built with ASan enabled at PE side. With it I tried to run the test suite, but every now and then I received a crash in wineserver. Because the management structure for the ASan shadow makes each wine process using several gigabytes memory I had a taskmgr.exe running all the time. I think this crash is a result of this taskmgr calling `NtQuerySystemInformation(SystemHandleInformation)` in conjunction with having many new processes created by the tests. This patch leaves `enum_handles` early if the last member has still the value -1 from `alloc_handle_table`. ``` Program received signal SIGSEGV, Segmentation fault. enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 846 if (!entry->ptr) continue; 1: x/i $pc => 0x55ec0b25ae6e <enum_handles+158>: cmpq $0x0,(%rdx) (rr) bt #0 enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 #1 0x000055ec0b268908 in enum_processes (cb=cb@entry=0x55ec0b25add0 <enum_handles>, user=user@entry=0x7ffce90cee30) at .../wine/wine/server/process.c:1112 #2 0x000055ec0b25c868 in req_get_system_handles (req=<optimized out>, reply=0x7ffce90cee90) at .../wine/wine/server/handle.c:875 #3 0x000055ec0b27d6eb in call_req_handler (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:304 #4 0x000055ec0b27e62a in read_request (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:338 #5 0x000055ec0b2896c0 in thread_poll_event (fd=<optimized out>, event=1) at .../wine/wine/server/thread.c:389 #6 0x000055ec0b2560b7 in fd_poll_event (event=<optimized out>, fd=<optimized out>) at .../wine/wine/server/fd.c:503 #7 main_loop_epoll () at .../wine/wine/server/fd.c:597 #8 0x000055ec0b25633e in main_loop () at .../wine/wine/server/fd.c:953 #9 0x000055ec0b246aa2 in main (argc=3, argv=0x7ffce90cf6c8) at .../wine/wine/server/main.c:238 (rr) print table->last $38 = -1 (rr) print table->count $39 = 32 ``` -- v2: server: Avoid crash when handle table is allocated but not yet filled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7035

2 2

[PATCH 0/1] MR7035: server: Avoid crash when handle table is allocated but not yet filled.
by Bernhard Übelacker (＠bernhardu) 17 Dec '24

17 Dec '24

I was experimenting with a Wine tree built with ASan enabled at PE side. With it I tried to run the test suite, but every now and then I received a crash in wineserver. Because the management structure for the ASan shadow makes each wine process using several gigabytes memory I had a taskmgr.exe running all the time. I think this crash is a result of this taskmgr calling `NtQuerySystemInformation(SystemHandleInformation)` in conjunction with having many new processes created by the tests. This patch leaves `enum_handles` early if the last member has still the value -1 from `alloc_handle_table`. ``` Program received signal SIGSEGV, Segmentation fault. enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 846 if (!entry->ptr) continue; 1: x/i $pc => 0x55ec0b25ae6e <enum_handles+158>: cmpq $0x0,(%rdx) (rr) bt #0 enum_handles (process=0x55ec0db97780, user=0x7ffce90cee30) at .../wine/wine/server/handle.c:846 #1 0x000055ec0b268908 in enum_processes (cb=cb@entry=0x55ec0b25add0 <enum_handles>, user=user@entry=0x7ffce90cee30) at .../wine/wine/server/process.c:1112 #2 0x000055ec0b25c868 in req_get_system_handles (req=<optimized out>, reply=0x7ffce90cee90) at .../wine/wine/server/handle.c:875 #3 0x000055ec0b27d6eb in call_req_handler (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:304 #4 0x000055ec0b27e62a in read_request (thread=thread@entry=0x55ec0db62c10) at .../wine/wine/server/request.c:338 #5 0x000055ec0b2896c0 in thread_poll_event (fd=<optimized out>, event=1) at .../wine/wine/server/thread.c:389 #6 0x000055ec0b2560b7 in fd_poll_event (event=<optimized out>, fd=<optimized out>) at .../wine/wine/server/fd.c:503 #7 main_loop_epoll () at .../wine/wine/server/fd.c:597 #8 0x000055ec0b25633e in main_loop () at .../wine/wine/server/fd.c:953 #9 0x000055ec0b246aa2 in main (argc=3, argv=0x7ffce90cf6c8) at .../wine/wine/server/main.c:238 (rr) print table->last $38 = -1 (rr) print table->count $39 = 32 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7035

3 2

[PATCH 0/1] MR7018: Revert "wined3d: Use bindless textures for GLSL shaders if possible."
by Elizabeth Figura (＠zfigura) 17 Dec '24

17 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7018

4 4

[PATCH 0/1] MR7021: wined3d: Add nop state entries for states now invalidated on the client side.
by Elizabeth Figura (＠zfigura) 17 Dec '24

17 Dec '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7021

4 3

[PATCH v2 0/6] MR7033: windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob.
by Nikolay Sivov (＠nsivov) 17 Dec '24

17 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/tests: Check persist options after Load(). windowscodecs/tests: Add loading tests for the writers. windowscodecs/tests: Add some tests for metadata stream objects handling. windowscodecs/tests: Add some tests for CreateMetadataWriter(). windowscodecs/tests: Add some tests for CreateMetadataWriterFromReader(). windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob. https://gitlab.winehq.org/wine/wine/-/merge_requests/7033

3 7

[PATCH 0/6] MR7033: windowscodecs/tests: Added some tests for Exif and Gps IFDs embedded in App1 blob.
by Nikolay Sivov (＠nsivov) 16 Dec '24

16 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7033

3 10

Re: [PATCH v2 0/1] MR7019: gdiplus: GdipPathAddRectangle should close the path. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7019

1 0

Re: [PATCH v2 0/1] MR7030: kernelbase: Don't try to print the path in the FIXME in GetTempPath2. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7030

1 0

Re: [PATCH v2 0/2] MR7029: Fix regression in variable expansion. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7029

1 0

Re: [PATCH v2 0/1] MR7025: winex11: Sync gl drawable outside of the win_data mutex. - approved
by Alexandre Julliard (＠julliard) 16 Dec '24

16 Dec '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7025

1 0

2025

2024

2023

2022

wine-gitlab